-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRITICAL: [Actionable Whispers] [$1250] Launch basic actionable whisper foundation #38533
Comments
Triggered auto assignment to @JmillsExpensify ( |
Job added to Upwork: https://www.upwork.com/jobs/~015906865d86966bf9 |
Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new. |
Upwork job price has been updated to $1000 |
Current assignees @shubham1206agra and @ishpaul777 are eligible for the External assigner, not assigning anyone new. |
ProposalPlease re-state the problem that we are trying to solve in this issue.The problem we are trying to solve is to implement "actionable whispers" for the Track Expense flow in the Expensify chat interface. After a user tracks an expense to their selfDM chat, we want to show a whisper message with actions the user can take on that expense, such as requesting someone else to pay it, categorizing it, or sharing it with their accountant. What is the root cause of that problem?Feature request What changes do you think we should make in order to solve the problem?To solve this, we should branch off #37282 and make the following changes:
|
This issue has not been updated in over 15 days. @JmillsExpensify, @thienlnam, @shubham1206agra, @ishpaul777 eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Hello @thienlnam, could we please adjust bounty here, it took a bit longer than expected and required more effort than initially expected : ) |
@JmillsExpensify, @thienlnam, @shubham1206agra, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Could you please add what you think is a fair amount and reasoning for it? |
i think $1250 should be fair becuase the track distance expense feature was introduced while the PR was almost ready and it took some more refactoring to have that flow covered |
That seems fair to me 👍 |
Upwork job price has been updated to $1250 |
Thank you! @thienlnam : ) |
@JmillsExpensify gentle bump for payment : ) |
Payment summary:
|
Offers sent out via Upwork. @shubham1206agra given that this is a new feature, please suggest a set of regression tests to ensure we keep quality high and are testing this for every QA run. |
@JmillsExpensify The steps are already provided in the Track Expense doc, so no need to write it here too. |
@thienlnam Have all the regression tests in the Track Expense doc been added to TestRail yet? |
All Contributors paid out, just wanted to confirm on regression tests for Track Expense before closing this out. |
@JmillsExpensify, @thienlnam, @shubham1206agra, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Yeah, they're being added https://github.com/Expensify/Expensify/issues/399663 |
We're adding the 'Track Expense' action in this PR. After tracking an expense to your selfDM, there will be a whisper action that provides different options you can take
Currently after each tracked transaction, there is another reportAction added which is called
ACTIONABLETRACKEXPENSEWHISPER
. This will be the actionable whisper.We already have a similar actionable whisper for inviting people here

There are 4 actions that can be taken
Request someone to pay it (Doc)
This will open up straight to the participant selector for the existing transaction. However, in this case it will move the transaction once the request is created as opposed to creating a new one.
API command: 'ConvertTrackedExpenseToRequest'
Parameters:
Categorize it (Doc)
This creates a workspace (if necessary), then moves it to the open expense report on the workspace chat, and opens the category editor.
API command: CategorizeTrackedExpense
Share it with my accountant (Doc)
This creates a workspace (if necessary), moves it to a report on the workspace chat, and opens the invite flow.
API command: ShareTrackedExpense
Nothing for now
Hides the actionable whisper
API command: DismissActionableWhisper
Note: To get started, you will need to branch off this existing PR. We haven't done full flow testing of the API commands, so there may be some additional BE changes that are required that you might find through working on this PR that we can work on in parallel.
We're also trying to launch this ASAP. Please do NOT pick this up unless you can spend your full attention on this
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: