-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-03-29] [Wave Collect] [$250] Taxes and Tags pages missing 12px space below page header #38547
Comments
Triggered auto assignment to @anmurali ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Taxes and Tags pages missing 12px space below page header What is the root cause of that problem?Missing padding of 12px here:
What changes do you think we should make in order to solve the problem?Add Result |
Job added to Upwork: https://www.upwork.com/jobs/~01c3fba734f748c3c2 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha ( |
Upwork job price has been updated to $250 |
Making a PR for this |
Current assignee @getusha is eligible for the Internal assigner, not assigning anyone new. |
Oh was about to post a proposal 😆 |
I knew you were 😂 |
I already posted 😅😆 |
wtf 😂 even github does not match the speed of the contributor proposal |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-29. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
$250 to @getusha for their testing and reviewer checklist on the PR |
I believe we wont need a regression test for this one, its a minor design issue which should be covered by exploratory testing or I am sure Shawn will post about it in expensify-bugs if this comes again :D |
🦅 👁️ |
@getusha have you received the payment here? |
Paid. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.54-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710778990402689
Action Performed:
Expected Result:
Each page should have 12px of padding below the page header and above the page content.
Actual Result:
These two pages are missing the 12px gap.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
![CleanShot 2024-03-18 at 12 23 45@2x](https://private-user-images.githubusercontent.com/38435837/313864641-2a12a53b-0891-4ffe-98d6-1ac4772b0310.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ1MTg2ODMsIm5iZiI6MTczNDUxODM4MywicGF0aCI6Ii8zODQzNTgzNy8zMTM4NjQ2NDEtMmExMmE1M2ItMDg5MS00ZmZlLTk4ZDYtMWFjNDc3MmIwMzEwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMjE4VDEwMzk0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVhNGFhNTI5NzBlNjA2NGNlMmM0NDMzNTAzNzNkMjAxMmRiN2NiMzE4NGQzOTNiZmQ5YzhkZTk0ZTkzNzBhMWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.jW1w4AMmG6y4eYy1Tvk8RCyY6osdDtYVxoh_j2BoJSg)
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @anmuraliThe text was updated successfully, but these errors were encountered: