Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-29] [Wave Collect] [$250] Taxes and Tags pages missing 12px space below page header #38547

Closed
1 of 6 tasks
m-natarajan opened this issue Mar 18, 2024 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Mar 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.54-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710778990402689

Action Performed:

  1. Open staging.new.expensify.com
  2. Go to Workspace Settings
  3. navigate to both Taxes and Tags

Expected Result:

Each page should have 12px of padding below the page header and above the page content.

Actual Result:

These two pages are missing the 12px gap.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
CleanShot 2024-03-18 at 12 23 45@2x

CleanShot 2024-03-18 at 12 21 57@2x

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c3fba734f748c3c2
  • Upwork Job ID: 1769872792516067328
  • Last Price Increase: 2024-03-18
Issue OwnerCurrent Issue Owner: @anmurali
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 18, 2024
Copy link

melvin-bot bot commented Mar 18, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Krishna2323
Copy link
Contributor

Krishna2323 commented Mar 18, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Taxes and Tags pages missing 12px space below page header

What is the root cause of that problem?

Missing padding of 12px here:

<View style={[styles.ph5, styles.pb5]}>

What changes do you think we should make in order to solve the problem?

Add styles.pt3 on the View.

Result

@mountiny mountiny self-assigned this Mar 18, 2024
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Mar 18, 2024
@melvin-bot melvin-bot bot changed the title Taxes and Tags pages missing 12px space below page header [$500] Taxes and Tags pages missing 12px space below page header Mar 18, 2024
Copy link

melvin-bot bot commented Mar 18, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01c3fba734f748c3c2

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 18, 2024
Copy link

melvin-bot bot commented Mar 18, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@mountiny mountiny changed the title [$500] Taxes and Tags pages missing 12px space below page header [Wave Collect] [$250] Taxes and Tags pages missing 12px space below page header Mar 18, 2024
Copy link

melvin-bot bot commented Mar 18, 2024

Upwork job price has been updated to $250

@mountiny mountiny added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Mar 18, 2024
@mountiny
Copy link
Contributor

Making a PR for this

Copy link

melvin-bot bot commented Mar 18, 2024

Current assignee @getusha is eligible for the Internal assigner, not assigning anyone new.

@allgandalf
Copy link
Contributor

Oh was about to post a proposal 😆

@mountiny
Copy link
Contributor

I knew you were 😂

@Krishna2323
Copy link
Contributor

I already posted 😅😆

@mountiny
Copy link
Contributor

wtf 😂 even github does not match the speed of the contributor proposal

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Mar 22, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Mar 22, 2024
@melvin-bot melvin-bot bot changed the title [Wave Collect] [$250] Taxes and Tags pages missing 12px space below page header [HOLD for payment 2024-03-29] [Wave Collect] [$250] Taxes and Tags pages missing 12px space below page header Mar 22, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 22, 2024
Copy link

melvin-bot bot commented Mar 22, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 22, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-29. 🎊

For reference, here are some details about the assignees on this issue:

  • @getusha requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Mar 22, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@getusha] The PR that introduced the bug has been identified. Link to the PR:
  • [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@getusha] Determine if we should create a regression test for this bug.
  • [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added the Overdue label Mar 31, 2024
@mountiny
Copy link
Contributor

$250 to @getusha for their testing and reviewer checklist on the PR

@anmurali
Copy link

anmurali commented Apr 2, 2024

Offer is here
@getusha can you add a regression test and complete the checklist?

@melvin-bot melvin-bot bot removed the Overdue label Apr 2, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 2, 2024

I believe we wont need a regression test for this one, its a minor design issue which should be covered by exploratory testing or I am sure Shawn will post about it in expensify-bugs if this comes again :D

@shawnborton
Copy link
Contributor

🦅 👁️

@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
@mountiny
Copy link
Contributor

@getusha have you received the payment here?

@getusha
Copy link
Contributor

getusha commented Apr 16, 2024

@getusha have you received the payment here?

Not yet @mountiny

@anmurali
Copy link

Paid.

@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2024
@github-project-automation github-project-automation bot moved this from Polish to Done in [#whatsnext] #wave-collect Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants