[HOLD for payment 2024-04-05] [$250] [Simplified Collect][Tags] - Deleted tag can be clicked on when deleted offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.-55-0
Reproducible in staging?: Y
Reproducible in production?: No, new feature
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User is admin of Collect workspace.
• The Collect workspace has tags.

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > Collect workspace.
3. Go to Tags.
4. Go offline.
5. Click on any tag.
6. Click 3-dot menu > Delete tag.
7. Delete the tag.
8. Click on the deleted tag and rename the tag.

Expected Result:

When a tag is deleted offline, app should prevent user from accessing the deleted tag.

Actual Result:

When a tag is deleted offline, user can access the deleted tag by clicking on it. When renaming a deleted tag, the tag is no longer deleted.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6420281_1710929192481.delete_tag.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0137a327ba3211534e
• Upwork Job ID: 1770409096694325248
• Last Price Increase: 2024-03-20
• Automatic offers:
• ntdiary | Reviewer | 0
• Krishna2323 | Contributor | 0

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@lschurr I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #wave-control.

[mountiny]

Its correct, users should not be able to click on the optimistically deleted tag anymore.

Not a blocker as this is not used by the customers yet. Going to open this to contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0137a327ba3211534e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[melvin-bot]

Upwork job price has been updated to $250

[Krishna2323]

@mountiny, I can handle this here: #38443. I already suggested to disable the tags.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tag - Deleted tag can be clicked on when deleted offline

What is the root cause of that problem?

We don't disable the tag when it has pending actions.

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Lines 85 to 95 in c1c054d

	Object.values(policyTagList.tags || [])
	.sort((a, b) => localeCompare(a.name, b.name))
	.map((value) => ({
	value: value.name,
	text: value.name,
	keyForList: value.name,
	isSelected: !!selectedTags[value.name],
	pendingAction: value.pendingAction,
	errors: value.errors ?? undefined,
	enabled: value.enabled,
	rightElement: (

What changes do you think we should make in order to solve the problem?

Add isDisabled property just like we have in WorkspaceCategoriesPage.

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 80 in c1c054d

const isDisabled = value.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || Object.values(value.pendingFields ?? {}).length > 0;

Result

[mountiny]

Its in tags, but this would work for any category, tag, distance and tax same @Krishna2323 please include it in your PR. Thank you!

[melvin-bot]

📣 @ntdiary 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@ntdiary, PR ready for review.

[ntdiary]

It seems like the expected behavior is still under discussion?

[trjExpensify]

@ntdiary what specifically about the expected behaviour?

1. If you delete a category offline, it should appear as "pending deleted" in the table which is greyed out with strikethrough. 2. You shouldn't be able to click the row to edit the details of it thereafter.

[ntdiary]

Ah, @trjExpensify, thank you for helping confirm it in that issue.

Agree with Tom. So the only instance in which we should disable the row is when it's pending to be deleted. Adding or updating any field should not block the user from interacting with it again.

Then, I think @Krishna2323 needs to tweak their PR implementation slightly, because in their PR, updating a field also disabled the row. :)

[mountiny]

Ok this will be ready for payment if no regressions $250 to @ntdiary and to @Krishna2323

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Tag - Deleted tag can be clicked on when deleted offline. #38725

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment automatic offer (Reviewer)
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ntdiary] Determine if we should create a regression test for this bug.
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

Payment summary:

• Contributor: @Krishna2323 $250 (paid in Upwork)
• Contributor+: @ntdiary $250 (paid in Upwork)

[ntdiary]

Contributor+: @ntdiary $250 (please accept the offer in Upwork)

@lschurr, thank you! Have accepted. 😄

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: Create WorkspaceTagsPage #37621
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37621/files#r1555481707
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@ntdiary] Determine if we should create a regression test for this bug. Don't have strong feeling, but will still provide regression steps first.
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. As below
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Regression steps:

1. Log in with an account that has a collect workspace.
2. Go to Profile > Workspaces > Collect workspace.
3. Go to Tags page.
4. Go offline.
5. Select any tag, then click 3-dot menu, and then delete that tag.
6. Hover or click the deleted tag and verify it is disabled with correct stylings.

[lschurr]

Great, we're all set!