[HOLD for payment 2024-04-05] [$125] Offline indicator is not at bottom of page on Workflows, and Categories, Tags empty state

[luacmartins]

Problem

Offline indicator does not show at the bottom of the page on the Workflows page and for Categories and Tags when showing the empty list component

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e4a7a9c86981e817
• Upwork Job ID: 1771187226329485312
• Last Price Increase: 2024-03-22
• Automatic offers:
• GandalfGwaihir | Contributor | 0

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e4a7a9c86981e817

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Upwork job price has been updated to $125

[bernhardoj]

I think this is a dupe of #37721?

[askavyblr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The offline indicator is not displayed at the bottom of the Workflows page, nor is it shown for Categories and Tags when the empty list component is presented.

What is the root cause of that problem?

offlineIndicatorStyle prop is missing in ScreenWrapper

What changes do you think we should make in order to solve the problem?

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 271 to 275 in 7b2a76f

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	style={[styles.defaultModalContainer]}
	testID={WorkspaceCategoriesPage.displayName}
	shouldShowOfflineIndicatorInWideScreen

need to pass offlineIndicatorStyle in ScreenWrapper, the same thing repeats for Workflows and tag page

What alternative solutions did you explore? (Optional)

N/A

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline indicator is not at bottom of page on Workflows, and Categories, Tags empty state

What is the root cause of that problem?

We do not pass offlineIndicatorStyle in ScreenWrapper:

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 271 to 276 in b9f3906

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	style={[styles.defaultModalContainer]}
	testID={WorkspaceCategoriesPage.displayName}
	shouldShowOfflineIndicatorInWideScreen
	>

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Lines 262 to 267 in 7b2a76f

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	style={[styles.defaultModalContainer]}
	testID={WorkspaceTagsPage.displayName}
	shouldShowOfflineIndicatorInWideScreen
	>

What changes do you think we should make in order to solve the problem?

We need to pass offlineIndicatorStyle={styles.mtAuto} to ScreenWrapper

Result

[allgandalf]

I think this is a dupe of #37721?

Note

the linked issue is for workflow page which will be solved by a different approach (Moving away from flatlist and using scrollView) by that issue, this issue is for Categories and tags Page :)

[luacmartins]

I think we should cover the categories/tags page here since that's not covered in that issue

[luacmartins]

Both @askavyblr and @GandalfGwaihir have pretty similar solutions so I'm gonna go with the first proposal by @askavyblr

[melvin-bot]

📣 @askavyblr You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[allgandalf]

@luacmartins they edited their proposal after me

[allgandalf]

This is what their initial proposal was:

Then i posted my proposal at 10:06pm IST :

Then they duped my proposal at 10:26 pm IST :

[allgandalf]

c.c. @luacmartins @eVoloshchak

[luacmartins]

Thanks for pointing that out @GandalfGwaihir and sorry that I missed that! I'll assign you to the job!

[melvin-bot]

📣 @GandalfGwaihir 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[luacmartins]

@askavyblr if you edit your proposal, you should post another comment mentioning that it was edited. From our contributing guidelines:

• If you want to make an entirely new proposal or update an existing proposal, please go back and edit your original proposal, then post a new comment to the issue in this format to alert everyone that it has been updated:

Please follow this procedure next time.

[allgandalf]

PR ready for review @eVoloshchak

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [FIX]: Offline indicator is not at bottom of page on Categories and Tags empty state #38832

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @GandalfGwaihir requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@GandalfGwaihir] Determine if we should create a regression test for this bug.
• [@GandalfGwaihir] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kadiealexander]

@GandalfGwaihir please don't forget the checklist!

[allgandalf]

actually @eVoloshchak is the C+ here , i’m C, melvin messes up sometimes 😆

[allgandalf]

Or no they were unassigned, @luacmartins reviewed the PR themself

[luacmartins]

This feature was in development at the time, so I don't think the checklist is applicable.

[kadiealexander]

Payouts due:

• Contributor: $125 @GandalfGwaihir

Upwork job is here.