-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hold for #395046] [Search v1] [$500] Add a search bar on the workspaces list #38854
Comments
Triggered auto assignment to @sonialiap ( |
Job added to Upwork: https://www.upwork.com/jobs/~016fc1028e9b86cc67 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak ( |
Hi Rory, can i make a proposal for this one? or is it already taken? |
📣 @hayes102! 📣
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Add a search bar on the workspaces list What is the root cause of that problem?This is a new feature What changes do you think we should make in order to solve the problem?We can re-use the filter logic in
What alternative solutions did you explore? (Optional)NA ResultScreen.Recording.2024-03-23.at.10.55.20.mov |
ProposalPlease re-state the problem that we are trying to solve in this issue.Add a search bar on the workspaces list What is the root cause of that problem?Feature Request What changes do you think we should make in order to solve the problem?Firstly, We don't need to create everything from scratch, we have major logic to filter workspaces in the App/src/pages/WorkspaceSwitcherPage.tsx Lines 147 to 153 in 191d932
Then we should define a App/src/components/OptionsSelector/BaseOptionsSelector.js Lines 506 to 532 in 2003844
Over here we also need to define a new Then we need to add this
And finally, Update the data parameter in
Test Branch: https://github.com/GandalfGwaihir/App/tree/issue38854 |
This is a feature request rather than a bug, so the first proposal to correctly explain the general idea of how to implement the feature - is a winning proposal. Extensive code diffs aren't needed (Source), the exact details of the implementation can be worked out during the PR review Based on that, I think we should proceed with @nkdengineer's proposal |
Current assignee @roryabraham is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
hello @eVoloshchak , i actually had the first dibs here, context: |
To prevent such situations, I suggest removing the 'Help Wanted' tag if the issue is specific to a particular individual. If the proposed assignment is unsatisfactory, then we can consider adding the tag to seek alternative solutions. I've experienced the same situation here 😆 |
@GandalfGwaihir, thanks for linking that! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
📣 @GandalfGwaihir 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@GandalfGwaihir all yours, looking forward to having a workspace search! 🙏 |
I think we should park the breaks on this and wait for search v2 and introducing it consistently. We purposefully left it out of the v1 of the Workspaces page knowing we'd be working into a more holistic search design. CC: @Expensify/design |
I agree with that. |
damn , the updated code was ready for one 😢 |
Agree with pausing this. It hasn't gone through our internal design process yet, though it will within the next 1-2 weeks, and at that point once we have alignment, we can pick this back up. |
Going to track it as part of |
@eVoloshchak, @sonialiap, @roryabraham, @GandalfGwaihir Eep! 4 days overdue now. Issues have feelings too... |
Not overdue, this is on HOLD |
@eVoloshchak, @sonialiap, @roryabraham, @GandalfGwaihir, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
search v2 is being worked on here https://github.com/Expensify/Expensify/issues/395046 |
Closing this out because it's a very long way from being implemented (slack) |
coming from https://expensify.slack.com/archives/C01GTK53T8Q/p1711147247599549...
Problem
If you have many workspaces on your workspaces list, it can be hard to find a particular one.
Solution
Add a search bar to filter the workspaces list.
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @GandalfGwaihirThe text was updated successfully, but these errors were encountered: