Workspace - Grammar error in "Let's get your company set up!" Concierge message

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.56.0
Reproducible in staging?: Y
Reproducible in production?: Y

Issue found when executing PR #38318

Action Performed:

1. Log into OD with a new expensifail account
2. OD: Create a Collect workspace with chat enabled
3. ND: Check Concierge chat

Expected Result:

It should be "Let's get your company set up! Your dedicated specialist...

Actual Result:

Grammar error in "Let's get your company set up!" Concierge message: "Let's get your company set up! , your dedicated specialist...". There is an extra comma between sentences

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ec26d4467a1a805c
• Upwork Job ID: 1772249919072411648
• Last Price Increase: 2024-03-25

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[laurenreidexpensify]

I can find and fix this. Not adding for external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ec26d4467a1a805c

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (Internal)

[laurenreidexpensify]

Pretty sure it's this - https://github.com/Expensify/Web-Expensify/blob/b200c54c18a51e8a1b142e8fc9170fe71b5aa14b/script/bwm/SendAssignedGuideMessaging.php#L19

[laurenreidexpensify]

Review will be on Expensify / Web so not applicable for C+ review

[laurenreidexpensify]

Actually it's this - https://github.com/Expensify/Web-Expensify/blob/423ff9df2a942fdeb3a4ff00ef242ad7fb50ecc4/script/bwm/SendAssignedGuideMessaging.php#L44

[laurenreidexpensify]

@lanitochka17 can you confirm the exact expensifail account you used to log in for the repro steps? Thanks

[laurenreidexpensify]

Need to clarify if we assign guides to expensifail accounts, cos I think this likely failing cos there is no Guide Name stored in the NVP and isn't a bug

[lanitochka17]

@laurenreidexpensify Tester used this account: [email protected]

[laurenreidexpensify]

@Gonals @cead22 @zsgreenwald see you worked on some of this code before - do you think this is a bug, or expected behaviour cos of the expensifail account being used to test?

[cead22]

Need to clarify if we assign guides to expensifail accounts, cos I think this likely failing cos there is no Guide Name stored in the NVP and isn't a bug

👍

@Gonals @cead22 @zsgreenwald see you worked on some of this code before - do you think this is a bug, or expected behaviour cos of the expensifail account being used to test?

Depends on how you look at it. I think the fact that we can send this without a guide name is a bug, and we should probably be checking for that, but it could also be that this test account is in a state that regular accounts wouldn't get to, and thus, it doesn't matter that we're not checking if the name is set

[cead22]

It looks like the assigned guide is [email protected] which has no name set

We could

1. Do nothing, and assume all guide's account are set up with names
2. Fall back on email when name isn't set
3. Optionally alert when a guide's name isn't set (when it's not "[email protected]")

I'd lean towards 1. until this happens for a non-test account

[laurenreidexpensify]

thanks for review @cead22

I lean towards 1 too - I don't think we need to write a code fix for this until we run into it on a non-test account either. Closing