[HOLD for payment 2024-04-05] Web - Expense report - Approve button not disabled if selected before enabling Self-approval

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.56-1
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #37348
Issue reported by: Applause - Internal Team

Action Performed:

precondition: user created a collect policy in OD, added a bank account, and set Direct reimbursements

1. Log in to OD as the admin of the collect policy
2. Navigate to the collect policy settings > Members
3. Enable the Prevent self-approval toggle
4. Log in to ND as the admin
5. Open the workspace chat and create a manual request
6. Disable the Prevent self-approval in OD
7. Refresh the page or open the report and submit the report in ND
8. Select Approve from the drop-down but do not click on it
9. Enable the the Prevent self-approval toggle in OD

Expected Result:

The approve button is disabled both on the report preview and in the expense report

Actual Result:

The approve button is not disabled if it was selected before enabling Self-approval. Clicking on the Approve button results in skeleton loading

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6424411_1711211397899.Recording__345.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[luacmartins]

Seems to have come from #37348

[francoisl]

Guessing it's not a blocker since collect policies are not available to users on NewDot yet.

@barros001 @alitoshmatov - looks like it might be coming from #37348 indeed – any idea on how we could fix this?

[barros001]

@francoisl I'll look into it as soon as I can and report back. By looking at the video (I have not had a change to look at code yet), I have a quick question: Under what circumstances would we want to have the Pay buttons visible/active while Approve is disabled? I raised this question while working on the original issue but we decided not to touch that logic as it was out of scope and we didn't want to break anything. If we really want to keep them there, then we'd have to make it so the button itself is disabled but then dropdown button (caret) is not so you can click and pick a different option.

[barros001]

If we want to keep the pay options, here's how this would look like. I'm not sure I like the look of it but this is such an edge case that I don't think it matters that much really. I'll open a PR with the change.

[barros001]

PR open for review. It assumes we do not want to touch the show/hide payment buttons logic and it only deals with the approve button.

[barros001]

Here's a video of how it behaves:

Screen.Recording.2024-03-25.at.5.50.42.PM.mov

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• disable main button when selected settlement option is disabled #38962

If no regressions arise, payment will be issued on 2024-04-05. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[francoisl]

All done here, fix is on production. The regression was fixed by the author of the PR that originally caused it, so I believe no payment is needed, but let me know if that's wrong.