Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-09] [Wave Collect][QBO] Allow collect admins to enable the Accounting Connection feature on the More Features page #38899

Closed
hayata-suenaga opened this issue Mar 24, 2024 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Mar 24, 2024

Add the Connections section on the More Features page. This new section allows the admins to toggle on the Accounting Connections feature.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bb6b6b32a1e23f36
  • Upwork Job ID: 1772048497857794048
  • Last Price Increase: 2024-03-24
@hayata-suenaga hayata-suenaga added Daily KSv2 NewFeature Something to build that is a new item. labels Mar 24, 2024
@hayata-suenaga hayata-suenaga self-assigned this Mar 24, 2024
@hayata-suenaga hayata-suenaga moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 24, 2024
Copy link

melvin-bot bot commented Mar 24, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 24, 2024
@hayata-suenaga hayata-suenaga added the Internal Requires API changes or must be handled by Expensify staff label Mar 24, 2024
Copy link

melvin-bot bot commented Mar 24, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01bb6b6b32a1e23f36

@hayata-suenaga hayata-suenaga added Daily KSv2 and removed Weekly KSv2 labels Mar 24, 2024
Copy link

melvin-bot bot commented Mar 24, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @cubuspl42 (Internal)

@alexpensify
Copy link
Contributor

alexpensify commented Mar 27, 2024

Daily Update: I think this should be weekly but Melvin keeps updating it to Daily.

@hayata-suenaga
Copy link
Contributor Author

sorry this should be daily I didn't have time to work on this recently. will planning to merge by the end of this week 🙇

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 28, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 2, 2024
@melvin-bot melvin-bot bot changed the title [Wave Collect][QBO] Allow collect admins to enable the Accounting Connection feature on the More Features page [HOLD for payment 2024-04-09] [Wave Collect][QBO] Allow collect admins to enable the Accounting Connection feature on the More Features page Apr 2, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 2, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@trjExpensify
Copy link
Contributor

@hayata-suenaga did you implement the locked toggles with this issue? Doc ref.

image

@hayata-suenaga
Copy link
Contributor Author

@hayata-suenaga did you implement the locked toggles with this issue? Doc ref.

Here is the issue I created 😄

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Daily KSv2 and removed Weekly KSv2 labels Apr 5, 2024
@alexpensify
Copy link
Contributor

alexpensify commented Apr 9, 2024

Payouts due: 2024-04-09

Upwork job is N/A

@alexpensify
Copy link
Contributor

@allroundexperts - closing for now, but please submit the payment request in Chat. Thanks!

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Apr 9, 2024
@JmillsExpensify
Copy link

$500 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
No open projects
Archived in project
Development

No branches or pull requests

6 participants