Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-04-25] [$250] HIGH: [Comment linking] Update thread headers / ancestry to deep link back to the original comment #38979

Closed
quinthar opened this issue Mar 26, 2024 · 34 comments
Closed

[HOLD for payment 2024-04-25] [$250] HIGH: [Comment linking] Update thread headers / ancestry to deep link back to the original comment #38979

quinthar opened this issue Mar 26, 2024 · 34 comments
Assignees
@puneetlath @rushatgabhane @jasperhuangg @rayane-djouah
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.

Comments

@quinthar
Copy link
Contributor

quinthar commented Mar 26, 2024 •
edited by melvin-bot bot
Loading

Problem:

When you click into a thread, the header says:

  • First line: (the comment that is being threaded)
  • Second line: From (the room containing the comment being threaded)

When you click the second line, it does open the parent room. However, it scrolls to the bottom of that room, losing context.

Solution:

Now that we have comment linking, when you click the second line, deep link directly to the comment that this thread is under.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013ec77e7b4b484ddd
  • Upwork Job ID: 1775298204363497472
  • Last Price Increase: 2024-04-02
  • Automatic offers:
    • rayane-djouah | Reviewer | 0
@quinthar quinthar converted this from a draft issue Mar 26, 2024
@quinthar
Copy link
Contributor Author

@perunt - Can you take this one?

@quinthar quinthar assigned quinthar and unassigned quinthar Mar 26, 2024
@quinthar
Copy link
Contributor Author

Actually, nevermind, dupe of this: #38722 (comment)

@github-project-automation github-project-automation bot moved this from HIGH to CRITICAL in [#whatsnext] #vip-vsb Mar 26, 2024
@rayane-djouah rayane-djouah mentioned this issue Mar 29, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 labels Mar 29, 2024
@quinthar
Copy link
Contributor Author

Reverted, reopening

@quinthar quinthar reopened this Mar 29, 2024
@rayane-djouah
Copy link
Contributor

👍

@quinthar quinthar moved this from CRITICAL to HIGH in [#whatsnext] #vip-vsb Mar 30, 2024
@quinthar quinthar assigned quinthar and rayane-djouah and unassigned quinthar Mar 30, 2024
@quinthar
Copy link
Contributor Author

@rayane-djouah What is your ETA for fixing this?

@rayane-djouah
Copy link
Contributor

@quinthar, I'll be addressing it this week. I anticipate completing it by the end of the week.
Shall we consider adding a bounty to this issue? This request entails extra work that wasn't initially scoped in the original issue, and it's worth noting that comment linking is a beta feature.

This was referenced Apr 2, 2024
Merged
Merged
Merged
@quinthar quinthar added External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. labels Apr 2, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 2, 2024

Job added to Upwork: https://www.upwork.com/jobs/~013ec77e7b4b484ddd

@melvin-bot melvin-bot bot changed the title HIGH: [Comment linking] Update thread headers / ancestry to deep link back to the original comment [$500] HIGH: [Comment linking] Update thread headers / ancestry to deep link back to the original comment Apr 2, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 2, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 2, 2024

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 2, 2024
@rayane-djouah
Copy link
Contributor

rayane-djouah commented Apr 11, 2024 •
edited
Loading

@rayane-djouah looks like we have an edge case #40027

could you please handle it? thanks!

Can do.

Edit:
PR: #40155

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 12, 2024
@quinthar
Copy link
Contributor Author

What's the ETA in this? Is anything blocking it? Can we get this done today?

@rayane-djouah
Copy link
Contributor

This is now on staging

@quinthar
Copy link
Contributor Author

Great!!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 18, 2024
@melvin-bot melvin-bot bot changed the title [$250] HIGH: [Comment linking] Update thread headers / ancestry to deep link back to the original comment [HOLD for payment 2024-04-25] [$250] HIGH: [Comment linking] Update thread headers / ancestry to deep link back to the original comment Apr 18, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 18, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 18, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 24, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 25, 2024

Issue is ready for payment but no BZ is assigned. @puneetlath you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 25, 2024

Payment Summary

Upwork Job

BugZero Checklist (@puneetlath)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1775298204363497472/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@puneetlath
Copy link
Contributor

Looks like @rayane-djouah implemented this and @rushatgabhane was the C+ is that right?

@rayane-djouah
Copy link
Contributor

Looks like @rayane-djouah implemented this and @rushatgabhane was the C+ is that right?

@puneetlath, Correct!

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 26, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 26, 2024

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@puneetlath
Copy link
Contributor

Payment Summary:

@rayane-djouah did you get an offer from the automation above?

@puneetlath
Copy link
Contributor

I think it's this one: https://www.upwork.com/nx/wm/offer/102047743

Ping me here when you've accepted @rayane-djouah

@rayane-djouah
Copy link
Contributor

@puneetlath, Offer accepted, Thanks!

@puneetlath
Copy link
Contributor

Ok great. @rayane-djouah has been paid. @rushatgabhane please request on NewDot.

Thanks everyone!

@JmillsExpensify
Copy link

$250 approved for @rushatgabhane

@johncschuster johncschuster mentioned this issue Jun 24, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@puneetlath puneetlath

@rushatgabhane rushatgabhane

@jasperhuangg jasperhuangg

@rayane-djouah rayane-djouah

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Projects
No open projects
[#whatsnext] #vip-vsb
Status: HIGH
Milestone
No milestone
Development

No branches or pull requests
6 participants
@quinthar @JmillsExpensify @puneetlath @rushatgabhane @jasperhuangg @rayane-djouah