Deleted Tasks inside threads are counted in the thread reply count

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.56-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @fedirjh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711463195704049

Action Performed:

1. Open a chat and Start a new thread
2. Create a new Task inside the thread
3. Navigate to task and delete it
4. Go back to main chat

Expected Result:

The correct number of replies is displayed for every thread

Actual Result:

Deleted task is counted in the thread reply count

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2906.mp4

CleanShot.2024-03-25.at.23.13.16.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[allgandalf]

I see deleted task message on my end so maybe it is intentional :

But if we don't want that then we need to call to update childVisibleActionCount:

App/src/libs/ReportUtils.ts

Line 3015 in f7a697a

function updateOptimisticParentReportAction(parentReportAction: OnyxEntry<ReportAction>, lastVisibleActionCreated: string, type: string): UpdateOptimisticParentReportAction {

[greg-schroeder]

I think this is expected and makes sense to me - the task is deleted but its existence is maintained by the deletion text, so I'm going to close this for now to focus on higher prio roadmap items

[fedirjh]

the task is deleted but its existence is maintained by the deletion text,

@greg-schroeder @GandalfGwaihir This is not the case for me. The deleted text tag disappears after some time.

CleanShot.2024-03-27.at.01.08.30.mp4

[bernhardoj]

@fedirjh oh, I just found out that we already have an issue for this here, so we can keep this closed.