-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Currency list is empty when trying to enter manually while the receipt is scanning #39022
Comments
Triggered auto assignment to @stephanieelliott ( |
Job added to Upwork: https://www.upwork.com/jobs/~019673dbcd358643b4 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale ( |
Going ahead and marking this as external. The currency selector seems completely broken. @stephanieelliott @akinwale let's make sure we add regression tests at the end of this. It shouldn't be possible to have this happen on prod. |
Agree with Puneet. I also realized this morning that I think this issue might originate from a cross currency issue, where the user's default currency is different than the policy currency. Please see this Slack thread for more videos. |
Seems like this is isolated to expensify.com email addresses. I was able to consistently repro on my expensify.com account, but could not repro on gmail.com or expensifail.com. I played around with cross currencies, but that didn't seem to have an effect on the currency selector. Specifically, I set my personal workspace to EUR and created a request on a USD workspace and was still able to use the currency selector from a gmail.com account, but not an expensify.com account. |
Waiting for some proposals on this one |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
So strange if this only impacts expensify.com. 🤔 |
@akinwale, @stephanieelliott Eep! 4 days overdue now. Issues have feelings too... |
I'm still only able to repro this on my expensify.com account, not on any other domains (expensifail, gmail, etc.). Given that its only affecting us internally on one platform I am not going to prioritize it but please comment if you feel differently! |
I feel like we should still figure it out and resolve it. It'll be a good opportunity for us to practice fixing a "real customer issue" in NewDot. One that the customer is able to reliably reproducible but that isn't reproducible by us. |
@akinwale @stephanieelliott this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
OK, @puneetlath does this seem like it can be fixed externally, or does it need to be kept internal? If having an |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Not sure! It could be a front-end issue that only we're experiencing for some reason. We could provide onyx data to an external contributor to help them try and figure it out. |
Ok, cool! I added a note to the issue body about the onyx data, and we'll work under the assumption that this can be fixed externally and will leave the labels as-is. Considering this discussion we'll wait for an external contributor to pick this up for now rather than pulling in an expert contrib. |
Issue not reproducible during KI retests. (First week) |
Waiting for proposals, see previous comment for context |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Waiting for proposals, see #39022 (comment) for context |
Issue not reproducible during KI retests. (Second week) |
Triggered auto assignment to @puneetlath ( |
Waiting for proposals, see #39022 (comment) for context. Reapplied the |
@puneetlath @akinwale @stephanieelliott this issue is now 4 weeks old, please consider:
Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@puneetlath, @akinwale, @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Issue not reproducible during KI retests. (Third week) |
I bet this is actually the same issue as #39455 and it's happening because OpenApp is failing and we aren't getting the currency list. Closing in favor of that issue. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v1.4.56-1
Reproducible in staging?: Yes
Reproducible in production?: Tes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711375359459619
Action Performed:
NOTE:
This seems to only occur to users logging in with an expensify.com email address. If you are interested in working on this bug we will provide Onyx data and an expensify.com test account.
Expected Result:
It’s possible to see/change currencies
Actual Result:
No currencies are visible
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
RPReplay_Final1711461631.MP4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: