Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Currency list is empty when trying to enter manually while the receipt is scanning #39022

Closed
1 of 6 tasks
m-natarajan opened this issue Mar 26, 2024 · 29 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@m-natarajan
Copy link

m-natarajan commented Mar 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.56-1
Reproducible in staging?: Yes
Reproducible in production?: Tes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711375359459619

Action Performed:

  1. Log in with an account on the expensify.com domain (ex: [email protected])
  2. Navigate to a workspace chat
  3. Tap grey plus button
  4. Choose Request money
  5. Scan receipt, save
  6. Tap into the expense while the receipt is scanning
  7. Tap the amount row
  8. Try to change the currency

NOTE:

This seems to only occur to users logging in with an expensify.com email address. If you are interested in working on this bug we will provide Onyx data and an expensify.com test account.

Expected Result:

It’s possible to see/change currencies

Actual Result:

No currencies are visible

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

RPReplay_Final1711461631.MP4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019673dbcd358643b4
  • Upwork Job ID: 1773009348580683776
  • Last Price Increase: 2024-04-24
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Mar 26, 2024
Copy link

melvin-bot bot commented Mar 26, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@puneetlath puneetlath added the External Added to denote the issue can be worked on by a contributor label Mar 27, 2024
@melvin-bot melvin-bot bot changed the title Currency list is empty when trying to enter manually while the receipt is scannig [$500] Currency list is empty when trying to enter manually while the receipt is scannig Mar 27, 2024
Copy link

melvin-bot bot commented Mar 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~019673dbcd358643b4

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 27, 2024
Copy link

melvin-bot bot commented Mar 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@puneetlath
Copy link
Contributor

Going ahead and marking this as external. The currency selector seems completely broken.

@stephanieelliott @akinwale let's make sure we add regression tests at the end of this. It shouldn't be possible to have this happen on prod.

@JmillsExpensify
Copy link

Agree with Puneet. I also realized this morning that I think this issue might originate from a cross currency issue, where the user's default currency is different than the policy currency. Please see this Slack thread for more videos.

@stephanieelliott
Copy link
Contributor

Seems like this is isolated to expensify.com email addresses. I was able to consistently repro on my expensify.com account, but could not repro on gmail.com or expensifail.com.

I played around with cross currencies, but that didn't seem to have an effect on the currency selector. Specifically, I set my personal workspace to EUR and created a request on a USD workspace and was still able to use the currency selector from a gmail.com account, but not an expensify.com account.

@stephanieelliott
Copy link
Contributor

Waiting for some proposals on this one

@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2024
Copy link

melvin-bot bot commented Apr 3, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@trjExpensify
Copy link
Contributor

So strange if this only impacts expensify.com. 🤔

Copy link

melvin-bot bot commented Apr 8, 2024

@akinwale, @stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

@stephanieelliott
Copy link
Contributor

I'm still only able to repro this on my expensify.com account, not on any other domains (expensifail, gmail, etc.). Given that its only affecting us internally on one platform I am not going to prioritize it but please comment if you feel differently!

@melvin-bot melvin-bot bot removed the Overdue label Apr 8, 2024
@puneetlath
Copy link
Contributor

I feel like we should still figure it out and resolve it. It'll be a good opportunity for us to practice fixing a "real customer issue" in NewDot. One that the customer is able to reliably reproducible but that isn't reproducible by us.

Copy link

melvin-bot bot commented Apr 9, 2024

@akinwale @stephanieelliott this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@stephanieelliott
Copy link
Contributor

OK, @puneetlath does this seem like it can be fixed externally, or does it need to be kept internal?

If having an expensify.com test account is the only thing keeping it internal it seems silly to block external eng from working on it -- I suppose we could create a test account if one doesn't exist already. Not sure whether back end changes are needed on this so wanted to confirm that first before figuring out a test account.

Copy link

melvin-bot bot commented Apr 10, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@puneetlath
Copy link
Contributor

OK, @puneetlath does this seem like it can be fixed externally, or does it need to be kept internal?

Not sure! It could be a front-end issue that only we're experiencing for some reason. We could provide onyx data to an external contributor to help them try and figure it out.

@stephanieelliott
Copy link
Contributor

Ok, cool! I added a note to the issue body about the onyx data, and we'll work under the assumption that this can be fixed externally and will leave the labels as-is. Considering this discussion we'll wait for an external contributor to pick this up for now rather than pulling in an expert contrib.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
@stephanieelliott
Copy link
Contributor

Waiting for proposals, see previous comment for context

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@mallenexpensify mallenexpensify changed the title [$500] Currency list is empty when trying to enter manually while the receipt is scannig [$500] Currency list is empty when trying to enter manually while the receipt is scanning Apr 15, 2024
Copy link

melvin-bot bot commented Apr 17, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@stephanieelliott
Copy link
Contributor

Waiting for proposals, see #39022 (comment) for context

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@stephanieelliott stephanieelliott added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 23, 2024
Copy link

melvin-bot bot commented Apr 23, 2024

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot removed the Overdue label Apr 23, 2024
@stephanieelliott
Copy link
Contributor

stephanieelliott commented Apr 23, 2024

Waiting for proposals, see #39022 (comment) for context.

Reapplied the Bug label to get another BZ member on this while I am OOO til May 2 which I guess is you @puneetlath! I'll pick this back up when I return but please keep an eye for any movement in the meantime

Copy link

melvin-bot bot commented Apr 23, 2024

@puneetlath @akinwale @stephanieelliott this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

Copy link

melvin-bot bot commented Apr 24, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Apr 25, 2024
Copy link

melvin-bot bot commented Apr 26, 2024

@puneetlath, @akinwale, @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week)

@puneetlath
Copy link
Contributor

I bet this is actually the same issue as #39455 and it's happening because OpenApp is failing and we aren't getting the currency list. Closing in favor of that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants