[Awaiting Payment 23rd April] [$250] Deprecate policy.role in favor of employeeList

[marcochavezf]

From this internal conversation, we want to deprecate policy.role in favor of employeeList to check the current user's role:

As a summary, I think ideally what we need to make happen is:
1. Update App so it fetches a policy role in the correct place (using employeeList, not top-level role which does not exist in the database)
2. Undo sending the role top-level policy attribute to Onyx

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d08fbf19a9080a89
• Upwork Job ID: 1782708664427339776
• Last Price Increase: 2024-04-23
• Automatic offers:
• shubham1206agra | Reviewer | 0
• getusha | Contributor | 0

[marcochavezf]

On hold for https://github.com/Expensify/Auth/pull/10367

[marcochavezf]

Still on hold

[flodnv]

Off HOLD 😄

[trjExpensify]

Removing the hold from the title then! Marco is out until Monday, so hopefully we can pick it up then.

[melvin-bot]

@marcochavezf Whoops! This issue is 2 days overdue. Let's get this updated quick!

[marcochavezf]

Sounds good, I will work on it tomorrow

[marcochavezf]

Ok, we'd need to deprecate policy.role first from the frontend in favor of employeeList and then remove all the policy.role instances from Auth. Looking for a contributor to help with the first part

[marcochavezf]

Assigning @shubham1206agra to implement the first part. Meanwhile, I will be working on the backend part.

[marcochavezf]

Hi @shubham1206agra, any update about the frontend implementation?

[shubham1206agra]

I will raise a PR tomorrow.
Approximately 20 small changes are there.

[marcochavezf]

Cool, thanks!

[marcochavezf]

PR for the backend change on hold

[shubham1206agra]

PR is up #40178
But we should hold this for #39489

[melvin-bot]

@marcochavezf, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[marcochavezf]

On hold for #40178

[trjExpensify]

@flodnv confirming we need to pay out $250 each to @getusha & @shubham1206agra for the work to date on the PR?

[flodnv]

Yes

[marcochavezf]

Assigning the bug label to handle the payment

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d08fbf19a9080a89

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[trjExpensify]

Offers have been sent to you both.

Confirming payment summary as follows:

• $250 to @getusha for partial review of the PR
• $250 to @shubham1206agra for the partial work on the PR

[shubham1206agra]

Accepted the offer

[trjExpensify]

Paid @shubham1206agra. @getusha let me know here when you accept, as this job in Upwork isn't assigned to me so I won't get a notification otherwise. :)

[getusha]

@trjExpensify accepted.

[melvin-bot]

@marcochavezf @trjExpensify @shubham1206agra @getusha this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[trjExpensify]

paid @getusha, closing!