[HOLD for payment 2024-04-09] Distance rates - App shows the same icon for Enable rate and Disable rate

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #38799

Action Performed:

Precondition:

• User is admin of Collect workspace
• The Collect workspace has at least one enabled and one disabled distance rate

1. Go to staging.new.expensify.com
2. Go to Profile > Workspaces > Collect workspace
3. Go to Distance rates
4. Select the enabled and disabled distance rate
5. Click on the dropdown menu

Expected Result:

App will show the correct icon for Enable rate

Actual Result:

App shows the same icon for Enable rate and Disable rate

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rates - App shows the same icon for Enable rate and Disable rate

What is the root cause of that problem?

We are using DocumentSlash instead of Document as icon.

App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

Line 223 in f8416e9

icon: Expensicons.DocumentSlash,

What changes do you think we should make in order to solve the problem?

Use Document.

Result

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rates - App shows the same icon for Enable rate and Disable rate

What is the root cause of that problem?

options.push({
    text: translate('workspace.distanceRates.enableRates', {count: disabledRates.length}),
    value: CONST.POLICY.DISTANCE_RATES_BULK_ACTION_TYPES.ENABLE,
    icon: Expensicons.DocumentSlash,
    onSelected: enableRates,
});

DocumentSlash icon is used here.

What changes do you think we should make in order to solve the problem?

Document icon should be used

options.push({
                text: translate('workspace.distanceRates.enableRates', {count: disabledRates.length}),
                value: CONST.POLICY.DISTANCE_RATES_BULK_ACTION_TYPES.ENABLE,
                icon: Expensicons.Document,
                onSelected: enableRates,
            });

[melvin-bot]

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

[mountiny]

@dubielzyk-expensify Just want to confirm the Expensicons.Document and Expensicons.DocumentSlash is what we want to use here?

[allgandalf]

It seems to be consistent with other pages:

But i was thinking about something more fancy like the DocumentPlus:

App/src/components/Icon/Expensicons.ts

Line 45 in f8416e9

import DocumentPlus from '@assets/images/document-plus.svg';

Any thoughts @dubielzyk-expensify , or should we go with the original Document icon 🤔

[mountiny]

yeah seems straightforward but not going to hurt to get Design eyes on this. I will handle this change internally.

[dubielzyk-expensify]

Yeah stick with that for now as that's what's in the intended design. I'll bring it to Slack for further discussion though

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use document icon for enabling the rates #39157

If no regressions arise, payment will be issued on 2024-04-09. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mountiny] Determine if we should create a regression test for this bug.
• [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

Nothing to do here now I think