[HOLD for payment 2024-04-09] [Wave Collect][QBO] Make it easy to conditionally add or remove routes/screens in WorkspaceSettingsModalStackNavigator

[hayata-suenaga]

As part of the QBO project, we're adding screens where workspace admins can configure accounting software integration. It's important that only admin users can access these screens.

The current code pattern doesn't allow for conditional access to screens/routes. Therefore, we need to refactor the code associated with the creation of navigators to facilitate the implementation of conditional or protected routes.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01959c603423a2c060
• Upwork Job ID: 1773049719285043200
• Last Price Increase: 2024-03-27

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01959c603423a2c060

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Current assignee @adelekennedy is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Extract WorkspaceSettingsModalStackNavigator #39084

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @situchan paid $250 via Upwork (https://www.upwork.com/nx/wm/offer/101826965)

BugZero Checklist (@twisterdotcom)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1773049719285043200/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[hayata-suenaga]

If we decide to not to use the pattern of conditional rendering the routes, we might want to undo changes made in this PR.

but for the payment, it's as usual for Situan who reviewed the PR

[twisterdotcom]

Okay, just going to pay @situchan $250 here.

[twisterdotcom]

Payment Summary:

• @situchan paid $250 here (C+)

[situchan]

@twisterdotcom I haven't received payment yet. Can you please check?
And work was done before price drop announcement.

[twisterdotcom]

Whoah you're right, I've no idea where this offer went. Try this now: https://www.upwork.com/nx/wm/offer/102382148

[situchan]

And work was done before price drop announcement.

@twisterdotcom can you please check this?

[twisterdotcom]

I just added a bonus to that payment: https://www.upwork.com/nx/wm/workroom/37321844/overview