Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD App PR #39094][Wave Collect][QBO] Use WORKSPACE_ACCOUNTING's getRoute when specifying the callback path for the QBO auth flow #39216

Closed
hayata-suenaga opened this issue Mar 28, 2024 · 13 comments
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Mar 28, 2024

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010f098ac205edac04
  • Upwork Job ID: 1779907490337906688
  • Last Price Increase: 2024-04-15
@hayata-suenaga hayata-suenaga added Daily KSv2 NewFeature Something to build that is a new item. labels Mar 28, 2024
@hayata-suenaga hayata-suenaga self-assigned this Mar 28, 2024
Copy link

melvin-bot bot commented Mar 28, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 28, 2024
@alexpensify
Copy link
Contributor

Noted to follow the GHS listed in the title.

@trjExpensify trjExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Apr 2, 2024
@trjExpensify
Copy link
Contributor

Making sure this is captured in release 1.

@alexpensify
Copy link
Contributor

Weekly Update:

#38283 has been deployed to staging
#39094 is in a draft PR

@hayata-suenaga
Copy link
Contributor Author

hayata-suenaga commented Apr 3, 2024

Weekly Update:
#38283 has been deployed to staging

Thank you very much for the update. A correction on the status of #38283 PR: It hasn't been merged yet 🙇

@alexpensify
Copy link
Contributor

Weekly Update: On hold and waiting on the other GHs.

@trjExpensify trjExpensify changed the title [HOLD App PRs #38283 #39094][Wave Collect][QBO] Use WORKSPACE_ACCOUNTING's getRoute when specifying the callback path for the QBO auth flow [HOLD App PR #39094][Wave Collect][QBO] Use WORKSPACE_ACCOUNTING's getRoute when specifying the callback path for the QBO auth flow Apr 15, 2024
@trjExpensify
Copy link
Contributor

The (new) PR for implementing the accounting page is done, so we're down to waiting on #39094 for authentication which is deep in review. @hayata-suenaga can you confirm if this is internal or external? The OP is a little... light. 😅 Thanks!

@hayata-suenaga hayata-suenaga added the Internal Requires API changes or must be handled by Expensify staff label Apr 15, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

Job added to Upwork: https://www.upwork.com/jobs/~010f098ac205edac04

Copy link

melvin-bot bot commented Apr 15, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @getusha (Internal)

@hayata-suenaga
Copy link
Contributor Author

Hello Tom thank you for keeping an eye on this one 😄 This issue is rather a memo I'm using to make sure that a certain code is used in the implementation. We might not have to do this depending on the outcome of the linked PR, but even if we have to do this, this is just one line change 🙇

@trjExpensify
Copy link
Contributor

Sounds good!

@trjExpensify
Copy link
Contributor

The PR for #39094 has been deployed to staging. Can we make an assessment on this one now, so we either close it or take it off hold? Thanks!

@hayata-suenaga
Copy link
Contributor Author

The PR uses the environment URL

onPress={() => Link.openLink(getQuickBooksOnlineSetupLink(policyID), environmentURL, false)}

we don't need to go ahead with this issue. Closing this now

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants