-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD App PR #39094][Wave Collect][QBO] Use WORKSPACE_ACCOUNTING
's getRoute
when specifying the callback path for the QBO auth flow
#39216
Comments
Triggered auto assignment to @alexpensify ( |
Noted to follow the GHS listed in the title. |
Making sure this is captured in release 1. |
Weekly Update: On hold and waiting on the other GHs. |
WORKSPACE_ACCOUNTING
's getRoute
when specifying the callback path for the QBO auth flowWORKSPACE_ACCOUNTING
's getRoute
when specifying the callback path for the QBO auth flow
The (new) PR for implementing the accounting page is done, so we're down to waiting on #39094 for authentication which is deep in review. @hayata-suenaga can you confirm if this is internal or external? The OP is a little... light. 😅 Thanks! |
Job added to Upwork: https://www.upwork.com/jobs/~010f098ac205edac04 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @getusha ( |
Hello Tom thank you for keeping an eye on this one 😄 This issue is rather a memo I'm using to make sure that a certain code is used in the implementation. We might not have to do this depending on the outcome of the linked PR, but even if we have to do this, this is just one line change 🙇 |
Sounds good! |
The PR for #39094 has been deployed to staging. Can we make an assessment on this one now, so we either close it or take it off hold? Thanks! |
The PR uses the environment URL
we don't need to go ahead with this issue. Closing this now |
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: