[HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Group chat - Group chat avatar leads to not here page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat.
3. Create a group chat.
4. Tap on the group chat header.
5. Tap on the group chat avatar.

Expected Result:

Group chat avatar opens in full screen view without issue.

Actual Result:

Group chat avatar leads to not here page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6431593_1711719921836.group_chat_avatar.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@adelekennedy I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

[marcaaron]

@blimpich grabbing this from ya since it's related to Group Chats.

[gijoe0295]

We set the icon.id as -1 here. Later when we navigated to ProfileAvatar page here, as the id was -1, we cannot find the corresponding avatar.

I think we should use ReportAvatar page for group avatar here.

if (icon.type === CONST.ICON_TYPE_WORKSPACE || icon.id === -1) {
    Navigation.navigate(ROUTES.REPORT_AVATAR.getRoute(reportID));
    return;
}

Then add specific logic for handling group avatar in ReportAvatar.

const isGroupChat = ReportUtils.isGroupChat(report);
const avatarURL = useMemo(() => (isGroupChat ? ReportUtils.getDefaultGroupAvatar(report?.reportID) : ReportUtils.getWorkspaceAvatar(report)), [report]);

Also set isWorkspaceAvatar={!isGroupChat} so we won't have a color background.

[marcaaron]

Thanks - that first link doesn't seem to go anywhere.

[gijoe0295]

I'm sorry. Just updated the correct reference.

[marcaaron]

We will soon modify this to allow adding a custom avatar. So, I think it would be ok to just disable opening an avatar for a Group Chat.

icon.id === -1 is pretty confusing. How about something like this:

diff --git a/src/components/RoomHeaderAvatars.tsx b/src/components/RoomHeaderAvatars.tsx
index 9298062aa6..ee75f91d58 100644
--- a/src/components/RoomHeaderAvatars.tsx
+++ b/src/components/RoomHeaderAvatars.tsx
@@ -15,8 +15,12 @@ type RoomHeaderAvatarsProps = {
     reportID: string;
 };

-function RoomHeaderAvatars({icons, reportID}: RoomHeaderAvatarsProps) {
+function RoomHeaderAvatars({icons, reportID, isGroupChat}: RoomHeaderAvatarsProps) {
     const navigateToAvatarPage = (icon: Icon) => {
+        if (isGroupChat) {
+            return;
+        }
+
         if (icon.type === CONST.ICON_TYPE_WORKSPACE) {
             Navigation.navigate(ROUTES.REPORT_AVATAR.getRoute(reportID));
             return;

diff --git a/src/pages/ReportDetailsPage.tsx b/src/pages/ReportDetailsPage.tsx
index 80563fcf7b..ccfe329419 100644
--- a/src/pages/ReportDetailsPage.tsx
+++ b/src/pages/ReportDetailsPage.tsx
@@ -218,6 +218,7 @@ function ReportDetailsPage({policies, report, session, personalDetails}: ReportD
                                 <RoomHeaderAvatars
                                     icons={icons}
                                     reportID={report?.reportID}
+                                    isGroupChat={ReportUtils.isGroupChat(report)}
                                 />
                             )}
                         </View>

[marcaaron]

QA re-testing now

[kavimuru]

This is a pass. Tapping the avatar does not navigate to anywhere.

39249.mp4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix Split Scan flow for Group Chats #39276

If no regressions arise, payment will be issued on 2024-04-09. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
• [@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@marcaaron] Determine if we should create a regression test for this bug.
• [@marcaaron] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix Split Scan flow for Group Chats #39276

If no regressions arise, payment will be issued on 2024-04-15. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
• [@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@marcaaron] Determine if we should create a regression test for this bug.
• [@marcaaron] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[adelekennedy]

@marcaaron what payment is due here? It looks like there are two connected PRs both reviewed by @s77rt - is the only payment due for the C+ PR reviews?

[s77rt]

No payment is due here. This is a part of a #32317

[s77rt]

• The PR that introduced the bug has been identified: Create Group Chats + Splits. #37458
• The offending PR has been commented on: Not needed. Author and Reviewer were tagged on the PR fixing this
• A discussion in #expensify-bugs has been started: n/a
• Determine if we should create a regression test for this bug: No

[s77rt]

Let's close this