Thread - Parent message with reply is highlighted in main chat after returning from thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Send a message
4. Right click on the message > Reply in thread
5. Send a reply in thread
6. Click on the header subtitle to return to main chat

Expected Result:

The parent message with reply in the main chat will not be highlighted permanently

Actual Result:

The parent message with reply in the main chat is highlighted permanently, until user opens another chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431591_1711719919905.thread_highlight.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[gijoe0295]

I think this is expected. It's a feature of comment linking.

[blimpich]

Demoting as this isn't a real blocker.

[blimpich]

@gijoe0295 I think the issue isn't that it is highlighting but that it is highlighted permanently. Do you think it's expected to be highlight permanently? I'm not sure.

[blimpich]

@roryabraham @perunt do you know if this is intended behavior with comment linking?

[gijoe0295]

I remembered once dbarett recommended to keep the highlight permanently. Let me search for that thread.

[roryabraham]

keeping the highlight permanently is indeed expected for now, and we're updating the color here.

We didn't discuss this edge case, but it makes sense to me that, when linking back to a parent thread, we would highlight the linked message just like we would when deep-linking to any other comment. I think this especially would make sense / feel more right if the thread was not at the end of the comment history but further back.

As such, I think we can close this as expected for now then maybe loop back in the future if we have a problem statement we feel confident about.