[HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Split Scan - Group created from split scan does not use the same avatar style as manual split

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat
3. Create a group chat
4. Note that the group chat avatar follows the new group avatar style
5. Go to FAB > Request money > Manual
6. Create a manual split request with two users with no chat history
7. Note that the group chat avatar follows the new group avatar style
8. Repeat Step 5 and 6 with scan split request

Expected Result:

The group chat avatar from the group with split scan will follow the same style as group from manual split

Actual Result:

The group chat avatar from the group with split scan does not follow the same style as group from manual split

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431597_1711719928216.group_split_scan.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-split

[marcaaron]

Thanks! This is expected behavior now. Since creating a Split will create a new Group Chat and not a Group DM (as we have deprecated creation of those).

[marcaaron]

Oh actually this is specific to scanning a receipt. Agree 🐛

[stitesExpensify]

@marcaaron should this just be treated as a normal external issue then?

[stitesExpensify]

Oh I didn't see that you re-assigned this to yourself. Thanks!

[melvin-bot]

Current assignee @marcaaron is eligible for the DeployBlockerCash assigner, not assigning anyone new.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcaaron]

I guess this doesn't have to be a blocker. However, I'd like to try to fix it (if it's not too complicated). It'd be great to close the loop on newly created Group DMs with this next release. It unblocks us to start completely migrating off of them in the backend.

[kavimuru]

Bug is fixed

Recording.1800.mp4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix Split Scan flow for Group Chats #39276

If no regressions arise, payment will be issued on 2024-04-09. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix Split Scan flow for Group Chats #39276

If no regressions arise, payment will be issued on 2024-04-15. 🎊

[melvin-bot]

@marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@marcaaron 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[marcaaron]

Gonna close this as it was a regression on the first Group Chats PR. @s77rt let me know if we need to reopen.