Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Workspaces - Tapping on any workspace does not lead to ws settings #39256

Closed
1 of 6 tasks
izarutskaya opened this issue Mar 29, 2024 · 17 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Mar 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4465764
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Prerequisites: Existing account with at least one workspace

  1. Log in to New Expensify with account from prerequisites
  2. Navigate to Workspaces
  3. Tap on any workspace

Expected Result:

User should be redirected to workspace settings.

Actual Result:

Nothing happens when tapping on any workspace.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6431637_1711721042403.OGRA6015.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ad5871d614b5d635
  • Upwork Job ID: 1773770639233683456
  • Last Price Increase: 2024-03-29
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 29, 2024
@melvin-bot melvin-bot bot added the Daily KSv2 label Mar 29, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@greg-schroeder I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@izarutskaya
Copy link
Author

Production

RPReplay_Final1711721501.MP4

@gijoe0295
Copy link
Contributor

I got this yesterday but no longer reproducible on main today. I think it's gone.

@neil-marcellini
Copy link
Contributor

I'm able to re-produce the problem on staging iOS. If the fix is on main, then we need to find whatever PR fixed it and CP it to staging.

@neil-marcellini neil-marcellini added the External Added to denote the issue can be worked on by a contributor label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ad5871d614b5d635

@melvin-bot melvin-bot bot changed the title Workspaces - Tapping on any workspace does not lead to ws settings [$500] Workspaces - Tapping on any workspace does not lead to ws settings Mar 29, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@neil-marcellini
Copy link
Contributor

Adding external since I would certainly appreciate any help spotting the fix

@allgandalf
Copy link
Contributor

I'm able to re-produce the problem on staging iOS

I wasn't able to reproduce on staging native iOS, was anyone else able to reproduce ?

@neil-marcellini
Copy link
Contributor

neil-marcellini commented Mar 29, 2024

I think this is the PR that fixed it. I'll make sure it was CPed to staging. Fix opening workspace settings on small screen

@parasharrajat
Copy link
Member

@neil-marcellini Please close the issue when done. Thanks.

@neil-marcellini
Copy link
Contributor

I have requested it to be CPed to staging here

@yuwenmemon yuwenmemon removed the DeployBlockerCash This issue or pull request should block deployment label Mar 29, 2024
@parasharrajat
Copy link
Member

Looks like this is solved. Can we please retest and close it?

@parasharrajat parasharrajat removed their assignment Apr 1, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 2, 2024

I cannot repro so this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

8 participants