[HOLD for Payment] HIGH: [Live Markdown] [$500] Fix inline image syntax in live markdown

[quinthar]

Problem:

We recently added the ability for "live markdown preview" meaning that we would preview the HTML formatting that the markdown generates. However, simultaneously we added a new markdown format: inline images (#37246). Right now there is a conflict where if you write the inline image format, it throws an exception:

Solution:

Fix the live markdown previewer to show the inline image.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017e2d18591b5166e5
• Upwork Job ID: 1773774252438794240
• Last Price Increase: 2024-04-05

[tomekzaw]

I would like to work on it

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017e2d18591b5166e5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[tomekzaw]

Adding support for parsing inline images in Live Markdown: Expensify/react-native-live-markdown#256

Currently blocked on Expensify/expensify-common#661 (comment)

[sakluger]

Hey @tomekzaw - what is the status here? Still blocked?

[quinthar]

Yep, curious for an ETA.

[tomekzaw]

We're still discussing the changes on the ExpensiMark side here: Expensify/expensify-common#661 (comment)

We should be able to add support for inline image syntax highlighting by EOW.

As for rendering an actual image underneath the text, we'll need some more time (we will track its progress in a separate issue) cc @thienlnam

[thienlnam]

As for rendering an actual image underneath the text, we'll need some more time (we will track its progress in a separate issue) cc @thienlnam

Yeah this would be a new feature - I'll create a new issue so we can track that

EDIT: Actually, I don't think we actually want this to happen. Is this referencing actually rendering the image below the live markdown within the composer? I think if we just fix the syntax formatting here that's about to the extent we want to update this

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[tomekzaw]

I think if we just fix the syntax formatting here that's about to the extent we want to update this

That's right, fixing the syntax formatting is the number one priority here.

I've asked @robertKozik to take over this task as it requires some small changes in ExpensiMark (already discussing that with @kidroca in Expensify/expensify-common#661 (comment)).

ETA: early next week

Yeah this would be a new feature - I'll create a new issue so we can track that

I agree with that rendering an actual image is a separate new feature; we'll need some designs and guidelines for that.

[shubham1206agra]

Linking the comment here. #39905 (comment)

[thienlnam]

We ended up bumping the version in a different PR, but @shubham1206agra went through a complete review so we should pay them for that

[shubham1206agra]

@tomekzaw Can you confirm that is there anything else remaining on this issue?

[tomekzaw]

@shubham1206agra I confirm that inline image syntax is already working as expected on current main so there's nothing left to do for this issue.

Thanks @kidroca for your changes in expensify-common and @robertKozik for your changes in Live Markdown!

FYI Inline image preview is tracked separately as a new feature in #40181.

[quinthar]

Great, can we close this?

[shubham1206agra]

@quinthar Payment is left here.

[shubham1206agra]

@sakluger Can you start payment process here?

[sakluger]

Handling payment now.

[sakluger]

I'm having a hard time following the GH issue. @shubham1206agra where is the PR that you reviewed? And was there a deploy blocker caused by this issue's PR?

[shubham1206agra]

@sakluger See #39275 (comment) and #39905 (comment)

[sakluger]

Okay, sounds like only @shubham1206agra is due payment. I've summarized it below. @shubham1206agra please let me know once you've accepted the offer.

Summarizing payment on this issue:

Contributor+: @shubham1206agra $500, sent offer via Upwork (https://www.upwork.com/nx/wm/offer/102102445)

[shubham1206agra]

@sakluger Accepted offer.

[sakluger]

Paid, thanks!