[HOLD PR #39343][$250] Thread-Cursor is hand cursor instead of text cursor when hovering over edit composer in thread

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.58-2
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Send a message in chat.
3. Right click on the message > Reply in thread.
4. Right click on the parent message in thread > Edit comment.
5. Hover over the text in the edit composer.

Expected Result:

The cursor should be text cursor when hovering over edit composer in thread (production behavior).

Actual Result:

The cursor is a hand cursor when hovering over edit composer in thread.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6432047_1711744850553.20240330_043709.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ae2c268d361e853b
• Upwork Job ID: 1774503212793540608
• Last Price Increase: 2024-03-31

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

Recording.2317.mp4

[thienlnam]

Not a blocker - added it to the main tracking issue #36071

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread-Cursor is hand cursor instead of text cursor when hovering over edit composer in thread

What is the root cause of that problem?

This issue related with PR #38722
here we added new parameter isClickable = !!onPress to getReportActionItemStyle to add style styles.cursorPointer when hover.
The issue here is we not exclude edit message case.

What changes do you think we should make in order to solve the problem?

We need to exclude edit message case when we pass isClickable here to be

// !!onPress
draftMessage === undefined && !!onPress

What alternative solutions did you explore? (Optional)

[ahmedGaber93]

@thienlnam this issue not related with Live Markdown, as I described in my proposal root cause.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ae2c268d361e853b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[mallenexpensify]

Pretty sure this can be External. Set price at $250 and added to #vip-vsb because the bug doesn't involve money.

@thienlnam let me know if anything above needs updating.
@hungvu193 , do you think this can be External? If so, can you review the proposal above? thx

[hungvu193]

@mallenexpensify Feel like this PR will fix this issue as well.
I think we can put it on hold.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mallenexpensify]

Thanks @hungvu193 , I put this on hold and removed External and Help Wanted

[melvin-bot]

This issue has not been updated in over 15 days. @tylerkaraszewski, @hungvu193, @mallenexpensify, @thienlnam eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[hungvu193]

The linked PR is merged, I think we can close this one 😄

[mallenexpensify]

Thanks @hungvu193 , we should be all good, closing (hahhaha, the screenshot doesn't show the cursor/hand, you'll have to trust me it's as expected)