-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] IOU Scan - In dark mode, the damaged PDF - file is barely visible #39356
Comments
Triggered auto assignment to @JmillsExpensify ( |
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.IOU Scan - In dark mode, the damaged PDF - file is barely visible What is the root cause of that problem?The root cause it that the App/src/components/PDFThumbnail/index.tsx Lines 20 to 29 in 80eb3b7
What changes do you think we should make in order to solve the problem?We need to add the custom component like we do in App/src/components/PDFView/WebPDFDocument.js Lines 96 to 99 in 80eb3b7
We might want to add default styles like Styles we use in
Result |
Proposal Updated.
|
ProposalPlease re-state the problem that we are trying to solve in this issue.In dark mode, the damaged PDF - text missing style What is the root cause of that problem?We can see how the same component in some places of the app, text is white and other areas, the text is dark. The used component App/src/components/PDFThumbnail/index.tsx Line 20 in aacfa8c
What changes do you think we should make in order to solve the problem?We should encapsulate the As example we can use + <View style={[styles.textVersion]}>
<Document
loading={<FullScreenLoadingIndicator />} |
cc @Expensify/design for thought on how to style the |
@JmillsExpensify Still overdue 6 days?! Let's take care of this! |
I think this is a good one to tackle as part of #wave-collect so I'm adding to that project. |
Job added to Upwork: https://www.upwork.com/jobs/~01caa5c1b848d17f6b |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani ( |
Thanks for the proposals @Krishna2323 @dragnoir . I like the idea of adding the custom error Text component to the Document component; we can go with @Krishna2323 's Proposal. 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@JmillsExpensify @jayeshmangwani @hayata-suenaga this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@hayata-suenaga What's your opinion on the proposal ? |
@JmillsExpensify, @jayeshmangwani, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Still working through the PR |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-18. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@JmillsExpensify, this issue was created before announcement, can you pls update the bounty? Thanks |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-20. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Regression Test Proposal
Do we agree 👍 or 👎 |
@JmillsExpensify Is it possible to get paid through NewDot for this job instead of Upwork? |
Payment summary:
|
@JmillsExpensify, this issue was created before announcement, can you pls update the bounty? Thanks |
Updated above since this was created a couple of days before the price change. @jayeshmangwani I canceled your Upwork contract. Please submit a request via NewDot. |
Requested on NewDot |
Contributor: @Krishna2323 paid $500 via Upwork |
$500 approved for @jayeshmangwani |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.58-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4467055
Issue reported by: Applause - Internal Team
Action Performed:
Pre-condition:use dark mode
Expected Result:
In dark mode, failed to load pdf message must be clearly visible while uploading corrupt pdf
Actual Result:
In dark mode, failed to load pdf message is barely visible while uploading corrupt pdf
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6434200_1711975273611.sis.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @JmillsExpensifyThe text was updated successfully, but these errors were encountered: