Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Cannot get rid of transaction threads *without RBRs* from the LHN #39385

Closed
2 of 6 tasks
m-natarajan opened this issue Apr 1, 2024 · 8 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: N/A
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): @LLPeckham and @heyjennahay
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @LLPeckham @heyjennahay
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711469490436519

Action Performed:

Precondition : Have 2 reimbursed expenses in a workspace chat and tag is disabled

  1. Open the app
  2. There are two unpinned expenses showing a red brick road (RBR) for the expenses
  3. Click each expense as submitter
  4. As a approver (Garrett) click on the expense as well

Expected Result:
I'd expect to be able to resolve the error creating the RBR (aka updating the missing category and missing tag) and the chats would go away from my chats pane as I do not have them pinned.

Actual Result:
When viewing on Chrome browser, I am unable to view one the expenses when clicking into it to view the issue causing the error, and for the other, I am unable to edit the error flagged on the expense as it shows as already submitted and approved in February.)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (2)

2024-03-26_16-05-23.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018f6068f20f37d8e5
  • Upwork Job ID: 1775259845349748736
  • Last Price Increase: 2024-04-02
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 1, 2024
Copy link

melvin-bot bot commented Apr 1, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@heyjennahay
Copy link

Noting that in both cases, the expenses are approved and therefore the submitter and approver cannot make changes to the expense, only an admin can. Based on this, the submitter should not be seeing a RBR on these expenses

@johncschuster johncschuster added the External Added to denote the issue can be worked on by a contributor label Apr 2, 2024
@melvin-bot melvin-bot bot changed the title Cannot get rid of RBR of the expense report in the LHN [$500] Cannot get rid of RBR of the expense report in the LHN Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

Job added to Upwork: https://www.upwork.com/jobs/~018f6068f20f37d8e5

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

@johncschuster
Copy link
Contributor

Thanks for clarifying that, @heyjennahay!

@JmillsExpensify JmillsExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #expense Apr 3, 2024
@cead22 cead22 changed the title [$500] Cannot get rid of RBR of the expense report in the LHN [$500] Cannot get rid of transaction threads *without RBRs* from the LHN Apr 3, 2024
@quinthar
Copy link
Contributor

quinthar commented Apr 5, 2024

I don't think we should do this, the server should not be sending these reports in the first place. Let's not introduce some kind of a hack on the client to ignore data that the server shouldn't be sending in the first place

@melvin-bot melvin-bot bot added the Overdue label Apr 5, 2024
@johncschuster
Copy link
Contributor

Oh nice! I didn't know the server shouldn't be sending these in the first place. In that case, I agree, we should address that instead.

@melvin-bot melvin-bot bot removed the Overdue label Apr 5, 2024
@cead22 cead22 closed this as completed Apr 5, 2024
@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #expense Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed
Projects
Archived in project
Development

No branches or pull requests

7 participants