[$500] Unable to mark system message unread in one transaction view

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Set up a collect policy with workspace chats (if necessary. Instructions here: https://expensify.slack.com/archives/C01GTK53T8Q/p1710887185511369?thread_ts=1710886648.492359&cid=C01GTK53T8Q)
2. Go to staging.new.expensify.com
3. Go to workspace chat that has no unsettled requests.
4. Create a manual request.
5. Set the category on the request.
6. Right click the set the category to "<category>". message and select "Mark as unread".
7. Scroll up and click New messages button.
8. Send a message in the report.
9. Mark the second message as unread.
10. Mark the first message (Expensify) as unread.

Expected Result:

The system message is marked as unread

Actual Result:

The system message is not marked as unread

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435569_1712063366945.20240402_210425.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01280f37ab9c88e291
• Upwork Job ID: 1775321731724582912
• Last Price Increase: 2024-04-17
• Automatic offers:
• paultsimura | Reviewer | 0
• nkdengineer | Contributor | 0

[melvin-bot]

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[amyevans]

Asked in #qa for what this looks like on prod

[amyevans]

Production:

bandicam.2024-04-02.17-31-26-884.mp4

[amyevans]

Asked in Slack for some help here and here, not making a ton of progress diagnosing this one

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01280f37ab9c88e291

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

[amyevans]

(Opening this up for help from the community but will pick up personally investigating it more tomorrow)

[amyevans]

One final thought for the night, I believe this is the new One Transaction Report view cc @NikkiWines, maybe you have a better sense of what's going on here?

[NikkiWines]

Yep, likely related. Probably because this logic (and hasNewestReportAction) wasn't updated when I added that view. I've noticed the scroll-down (and indicator display) works fine with reportActions that occur on the report (e.g. commenting) but not with actions that occur on the expense (updating the merchant)

I'll look into a fix but this wasn't accounted for in the initial PR we can maybe remove the blocker label for the moment since it's an easy work around for a one-expense report. What do you think?

[NikkiWines]

Ooh actually, I think this might end up being resolved as a byproduct of implementing this proposal because it updates the logic in getOriginalReportID which we use in generating the unread indicator. I'd be curious to retest this once those changes are implemented

[jasperhuangg]

I'll look into a fix but this wasn't accounted for in the initial PR we can maybe remove the blocker label for the moment since it's an easy work around for a one-expense report. What do you think?

@NikkiWines that sounds good to me, thanks for clarifying things here. I'll go ahead and remove the blocker label since it looks like this is going to be resolved soon.

[amyevans]

I've noticed the scroll-down (and indicator display) works fine with reportActions that occur on the report (e.g. commenting) but not with actions that occur on the expense (updating the merchant)

Okay nice, this made it a lot easier to test locally than fumbling around with SmartScan. I was able to reproduce by just creating an expense and updating a field on it, as you said.

I retested following the merge of the fix you mentioned (#39474), unfortunately the issue is still reproducible:

Screen.Recording.2024-04-03.at.3.14.48.PM.mov

• Any expense level report action cannot be marked unread
• If the latest report action on the report is from the expense level, the New messages button does not scroll you down

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[NikkiWines]

Unfortunately, no - we've got some competing priorities currently, and this is a fairly esoteric bug for a user to encounter so it's not as high of a priority at this time.

[melvin-bot]

This issue has not been updated in over 15 days. @amyevans, @paultsimura, @sonialiap, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[amyevans]

Apologies as I should have probably done this a month ago when my bandwidth was looking low, but I'm unassigning from this GH since I'm out on extended leave after today.

Hopefully another internal engineer will be able to pick it up and help get it over the line, but as Nikki pointed out it is unfortunately not high priority on our roadmap so it may take a bit.

[sonialiap]

Adding retest label since this has been open for over a month so that QA can retest to confirm if this is still an issue 🙏

[sonialiap]

Asked for a retest in slack

[kavimuru]

@sonialiap still reproduced.

20240702_222248.mp4

[sonialiap]

Thanks Kavi!

[mvtglobally]

Issue is reproducible during KI retests.

[sonialiap]

VSB is on hold so I'm going to wait to ask for internal volunteers

[sonialiap]

checking if we should close

[sonialiap]

confirmed that this is not a priority, closing for now

[nkdengineer]

@sonialiap Should we be eligible for compensation here since we spent effort on the PR, the change is almost done, and we are only waiting for the BE change, thanks. We have the same case here.

[sonialiap]

Payment summary:

• @paultsimura $500 - paid in upwork
• @nkdengineer $500 - paid in upwork