-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for Payment 2024-04-30] [$500] BA - Disconnected bank account is still displayed on bank account preview on Workflows page #39439
Comments
Triggered auto assignment to @hayata-suenaga ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Linking closed and fixed KI #38200 |
@kbecciv, am I correct to understand that the fix for this issue has been deployed to production in the PR you linked and the issue is no longer reproducible both on staging or production? The linked PR appears to have been deployed to production about 11 hours ago. I don't know why this issue was detected on staging about 2 hours ago. |
@hayata-suenaga Tester reproduced this bug. bandicam.2024-04-02.20-09-26-330.mp4 |
I'll reopen this issue as the QA team was able to reproduce this. However, we cannot confirm if this issue exists in production or not as we don't have a test bank account that we can use on production. So, I'll treat this as a normal bug issue. |
Triggered auto assignment to @sakluger ( |
Job added to Upwork: https://www.upwork.com/jobs/~018935ae4d1df3ea3c |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Disconnected bank account is still displayed on bank account preview on Workflows page What is the root cause of that problem?When we disconnect bank account and get on the workflow page, we do not fetch the latest data as we only call it once when we load the page at the start: App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx Lines 81 to 84 in 7177173
What changes do you think we should make in order to solve the problem?Add a dependency of What alternative solutions did you explore? (Optional)N/A |
ProposalPlease re-state the problem that we are trying to solve in this issue.The bank account is still displayed on the preview after the account has been disconnected. What is the root cause of that problem?The workspace workflows page relies on the However, when we disconnect the bank account, we're not setting So the bank account preview will still show. What changes do you think we should make in order to solve the problem?Set Sample code:
What alternative solutions did you explore? (Optional)If we only want the bank account preview to disappear after the API request to disconnect is successful, we can set We might need to set We can consider optimistically update the |
Current assignee @hayata-suenaga is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @nkdengineer You have been assigned to this job! |
Bump @nkdengineer |
Will open PR today. |
@rayane-djouah The PR is here. |
Deployed to production #40226 (comment) |
@sakluger, please remove the Reviewing label and bump to Daily as payment is due |
Sent an offer to @nkdengineer: https://www.upwork.com/nx/wm/offer/102102495/ |
Summarizing payment on this issue: Contributor: @nkdengineer $500, sent offer via Upwork (https://www.upwork.com/nx/wm/offer/102102495/) @rayane-djouah please complete the BZ checklist. |
@nkdengineer please let me know once you've accepted the offer. @rayane-djouah bump on the BZ checklist. |
I completed payment to @nkdengineer. Now just waiting on the BZ checklist before we can close the issue. |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression test proposal
|
Thanks! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4469599
Issue reported by: Applause - Internal Team
Action Performed:
Pre-requisite: user must be logged in, have created a collect workspace and have connected a bank account.
Expected Result:
The bank account should not be displayed on the preview after the account has been disconnected.
Actual Result:
The bank account is still displayed on the preview after the account has been disconnected.
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6435967_1712085957572.Aokm2842_1_.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @rayane-djouahThe text was updated successfully, but these errors were encountered: