[HOLD for payment 2024-06-05] [One expense reports] System message for request edit does not show up in LHN when there is a single request

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Request money > Manual.
3. Create a manual request with user that has no chat history.
4. Go to combined IOU report.
5. Edit any field.
6. Note that the system message does not show up in LHN.
7. Send a message.
8. Note that the message shows up in LHN.

Expected Result:

In Step 5, the system message for request edit will show up in LHN.

Actual Result:

In Step 5, the system message for request edit does not show up in LHN.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435877_1712080691958.20240403_015434.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[NikkiWines]

Oh interesting, this is due to the changes implemented here: #36934

Technically this is expected because those actions are occurring on the expense level (they're modifying things like the expense description and the expense amount) and the preview in the LHN is for the report level, so you'd see things like comments or actions taken by the admin on the report (approving / paying / rejecting, etc.).

We should probably update it so the LHN has the combo reportActions for the report and transactionThread, but I don't think this is a blocker for now - it's not something we discussed in the initial implementation.

@cead22 what do you think?

[cead22]

To clarify, this is expected as of that change you linked, right? Cause it happens on staging but not production.

We should probably update it so the LHN has the combo reportActions for the report and transactionThread, but I don't think this is a blocker for now - it's not something we discussed in the initial implementation.

That sounds fine to me, but maybe we should take this through product or discuss with whomever was involved in the original discussion about the change, since I wasn't aware we were updating this

[NikkiWines]

To clarify, this is expected as of that change you linked, right?

yes, it's definitely the result of that change

That sounds fine to me, but maybe we should take this through product or discuss with whomever was involved in the original discussion about the change, since I wasn't aware we were updating this

it's been in the works for a while and we're seeing a couple of edge cases that are bubbling up as a result of this change and the hybrid reportActions.

[melvin-bot]

This issue has not been updated in over 15 days. @NikkiWines eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update LHN to display transaction level actions for one-transaction reports #42005

If no regressions arise, payment will be issued on 2024-06-05. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@NikkiWines Eep! 4 days overdue now. Issues have feelings too...

[NikkiWines]

This can be closed out