Expense - Missing react & reply in thread for system message in one transaction report view

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat that has no unsettled report.
3. Create a manual request.
4. Click on the request preview to go to one transaction report view.
5. Edit the amount or any other field.
6. Right click on the system message.
7. Note that there is no option to react and reply in thread.
8. Create a second request.
9. Go to transaction thread of first request.
10. Right click on the system message.
11. Now there is option to react and reply in thread.

Expected Result:

System message for request edit should have the option to react and reply in thread in one transaction report view.

Actual Result:

System message for request edit does not have the option to react and reply in thread in one transaction report view.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6436003_1712087675810.20240403_034941.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[mountiny]

I dont think this has to be a blocker cc @NikkiWines

Its not really blocking users so much they can normally comment in the report they are in.

[mountiny]

@NikkiWines I think it might be tricky to allow threading from that comment, as its technically on different report than you are seeing. Going to that thread (which cannot be created now), we would need to make sure the report header links to the expense report and not to the thansaction thread 🤔

[NikkiWines]

Oof, yeah that's another complexity I don't think we considered when designing this view. We might need to raise in slack the best way to handle this 🤔 I didn't even realize you could comment on system messages 😅

But yes for now, not a blocker.

[NikkiWines]

I'm actually not seeing this behavior any more on staging, though i might be seeing a new bug where threads created on the transaction-level system messages can't be deleted. But we also had a bug around deleting messages show up recently so I'm not sure if it's specific to this view or not

(threading and reacting)

Screen.Recording.2024-04-05.at.10.59.53.mov

(trying to delete the response)

Screen.Recording.2024-04-05.at.11.00.29.mov

[thienlnam]

@NikkiWines Can I reassign this to you since it seems like you have the context for this?

[NikkiWines]

Confirmed that the re-appearing deleted comment occurs on both the single and multiple transaction reports, so it's not a bug tied to the one-transaction view. Looks like we can close this out since the react + reply functionality works fine in both views 👍

(Standard (multiple) transaction report)

Screen.Recording.2024-04-08.at.11.20.29.mov

(One-transaction report)

Screen.Recording.2024-04-08.at.11.17.37.mov