[HOLD for payment 2024-06-24][$1000] Correct chat is not opening when typing someone's name and hit Enter in chat switcher

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.60-1
Reproducible in staging?: Yes
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @flodnv
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712242871375939

Action Performed:

Note: This seems to only (or maybe mainly) happen immediately after startup.

1. Quit and restart desktop app
2. Change chat with the mouse (click on another chat in the LHN)
3. Change chat with chat switcher, all using the keyboard
4. Hit enter to go to other chat
5. Observe that I am still in the same chat

OR

1. Quit and restart desktop app
2. Change chat with chat switcher all using the keyboard (hit Cmd+K),
3. Hit enter to go to another chat (not the currently open one)
4. Observe that I am still in the same chat

Expected Result:

Navigates to the correct chat

Actual Result:

Observe app didn't navigate to that chat but stayed on the original one

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2024-04-04_09-52-30.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01741289e82422ca9a
• Upwork Job ID: 1775934748241137664
• Last Price Increase: 2024-06-03
• Automatic offers:
• fedirjh | Reviewer | 102862846
• dominictb | Contributor | 102862847

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[adelekennedy]

I can't reproduce reliably (but that's the same for Matt and Flo) however I think this is annoying enough that we should fix

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01741289e82422ca9a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[adelekennedy]

@fedirjh do you think this can be an external issue?

[fedirjh]

do you think this can be an external issue?

@adelekennedy Yes, it's external. However, I am unable to reproduce it.

CleanShot.2024-04-04.at.18.29.14.mp4

[adelekennedy]

same - however both Flo and Matt are able to reproduce intermittently so I think it's worth it to fix as it's a pretty frustrating one

[melvin-bot]

📣 @reliablesoftdev! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[borthdor]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0182fe2385ff400511

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[ShridharGoel]

@m-natarajan @flodnv Can you add the correct video showing the bug?

[MrMuzyk]

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

[MrMuzyk]

@m-natarajan I've tried multiple times but I couldn't reproduce this issue. Am I missing something?

39631_no_repro.mp4

[flodnv]

It's hard because I only encounter this bug like 15% of the time when switching chats. Ah, got it, desktop version v1.4.60-13.

Here's what I did:

1. Quit and restart desktop app
2. Change chat with the mouse (click on another chat in the LHN)
3. Change chat with chat switcher, all using the keyboard (note another bug observed here, the original text I typed disappeared on its own, I'll make sure this gets reported as well)
4. Hit enter to go to other chat
5. Observe that I am still in the same chat

Screen.Recording.2024-04-08.at.10.47.45.AM.mov

I was able to reproduce 3 times in a row using these exact test steps.

[adelekennedy]

waiting for proposals

[MrMuzyk]

Unfortunately Im still unable to reproduce that even with the updated steps (see the video). Recording was done on latest main. Maybe it's something related to this particular account, I'm not sure :(

39237-cant-repro.mp4

[adelekennedy]

oof - Both @flodnv and @mallenexpensify can reliably reproduce, but I can't (even with the updated instructions as well) In this case @MrMuzyk how would you move forward? If it's account specific is there a way for us to mimic those account conditions?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: add universal build for desktop app #43505

If no regressions arise, payment will be issued on 2024-06-24. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dominictb]

hey guys, since the PR that fix both this issue and #42558, and even though they shared the solution, I had posted 2 proposals for those 2 issues (with clear explanation of the root cause and solutions for each respective issue), should I receive the bounty of this issue as well? Thanks all!

[mallenexpensify]

@dominictb , possibly. This is def an edge case cuz it doesn't appear the root causes were the same for each.
Did you have to do additional work on the PR so that both issues would be fixed? If so, that could be used as justifcation (increased scope of work).

@fedirjh are you due compensation, it looks like @eh2077 reviewed the PR.

[dominictb]

Did you have to do additional work on the PR so that both issues would be fixed

@mallenexpensify, the PR: #43505 is for the #42558. However, that PR is only part 1 of my proposal for this issu here #39631 (comment), and I also have an optional second part. So I think let's unhold this issue and let's @fedirjh review it to see if I need to implement the second part?

However, it seems to me once #43505 is merged, this issue will solve itself on the latest version. If @fedirjh decides that's the case, maybe another thing to consider if we decide to close this issue to increase the bounty of #42558 to $1000, as it was also created long time ago and nobody looked into that until me?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: add universal build for desktop app #43505

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

However, it seems to me once #43505 is merged, this issue will solve itself on the latest version.

I was unable to reproduce now on staging. @fedirjh can you attempt reproduction?

@dominictb , for compensation, I think, at least, $1k is fair, since that's the price of this job and your PR fixed it. Since the PR #43505, also intentionally fixed another bug (ie. it wasn't random that it happened), I don't see why you wouldn't be due comp there too. (or... put another way, one PR fixed two issues but the work in the PR was more than if you only created it to fix one bug).

[dominictb]

@mallenexpensify got it! Thanks for the input! I guess when things are due, I'll ping both issues then.

Do I need to be assigned here first?

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mallenexpensify]

@fedirjh @dominictb , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01741289e82422ca9a

Fedi, the assignment of this job predates your eligible date to be paid via NewDot.

[fedirjh]

@mallenexpensify I think I am not eligible for payment in this issue.

[dominictb]

@mallenexpensify I accepted the job, TY

[mallenexpensify]

Contributor: @dominictb paid $1000 via Upwork

Thanks @fedirjh , it looks like you didn't review the PR nor any proposals here.

@dominictb I've been running into an issue where, after typing cmd+k then typing a user's name, I need to hit enter twice to open the chat. Might that be related here? (sidenote: I'm also stuck a couple versions back on desktop

TestRail GH

• https://github.com/Expensify/Expensify/issues/407748

[dominictb]

I'm not sure @mallenexpensify. Could you report a bug?

Also, I couldn't access the link https://github.com/Expensify/Expensify/issues/407748 (internal-only link).