Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for Payment 2024-05-29][Wave Collect] [Xero] [Import Flow] Create the Chart of Accounts page #39731

Closed
lakchote opened this issue Apr 5, 2024 · 15 comments
Assignees
Labels
Daily KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@lakchote
Copy link
Contributor

lakchote commented Apr 5, 2024

You need to build the page following the steps outlined here.

This will be worked on by SWM engineers, see Slack discussion here.

Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet.

EDIT: You'll need to implement the latest design changes here, just like in QBO.

@lakchote lakchote added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 5, 2024
@lakchote lakchote moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 5, 2024
@SzymczakJ
Copy link
Contributor

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

@lakchote lakchote changed the title [Wave Collect] [Xero] [Import Flow] Create the Chart of Accounts page [HOLD #39727] [Wave Collect] [Xero] [Import Flow] Create the Chart of Accounts page Apr 15, 2024
@trjExpensify trjExpensify moved this from Release 1: Spring 2024 (May) to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect Apr 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 18, 2024
@slafortune
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Apr 25, 2024
@slafortune
Copy link
Contributor

pr merged

@lakchote
Copy link
Contributor Author

lakchote commented May 3, 2024

pr merged

Hmm, there's no PR for it it seems. Did you think about the QBO one?

@lakchote lakchote changed the title [HOLD #39727] [Wave Collect] [Xero] [Import Flow] Create the Chart of Accounts page [Wave Collect] [Xero] [Import Flow] Create the Chart of Accounts page May 3, 2024
@trjExpensify
Copy link
Contributor

Making you guys aware of this update coming with QBO. We should align here for Xero as well. That would give us this:

Image

@lakchote lakchote self-assigned this May 8, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 9, 2024
@trjExpensify
Copy link
Contributor

Deployed to staging yesterday. Assigning @s77rt as he'll need to be paid for the C+ review of the linked PR once this hits production and the 7 day regression period passes.

@slafortune
Copy link
Contributor

slafortune commented May 23, 2024

This went to production on May 22 -
image
That would make the payment due on May 29th - no automation - I'll update the GH title
I'll be on vacation until June 4th - so adding another BZ for payment

@s77rt will be due $500 via Upwork C+ Role - offer sent here
@SzymczakJ Contributor role is an expert contributor and not due payment here.

@slafortune slafortune removed the NewFeature Something to build that is a new item. label May 23, 2024
@slafortune slafortune removed their assignment May 23, 2024
@slafortune slafortune added the NewFeature Something to build that is a new item. label May 23, 2024
Copy link

melvin-bot bot commented May 23, 2024

Triggered auto assignment to @laurenreidexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@s77rt
Copy link
Contributor

s77rt commented May 23, 2024

@slafortune Accepted! Please note the amount due here is $250

@slafortune
Copy link
Contributor

@laurenreidexpensify when paying on the 29th, please pay a different price of $250, I accidentally created the contract for $500. TIA!!

@laurenreidexpensify laurenreidexpensify changed the title [Wave Collect] [Xero] [Import Flow] Create the Chart of Accounts page [HOLD for Payment 2024-05-29][Wave Collect] [Xero] [Import Flow] Create the Chart of Accounts page May 28, 2024
@laurenreidexpensify laurenreidexpensify added Daily KSv2 and removed Weekly KSv2 labels May 28, 2024
@laurenreidexpensify
Copy link
Contributor

laurenreidexpensify commented May 29, 2024

Payment Summary:

@s77rt $250 via Upwork C+ Role - offer sent here
@SzymczakJ Contributor role is an expert contributor and not due payment here.

@laurenreidexpensify
Copy link
Contributor

@s77rt I was on autopilot and paid $500 by mistake but requested a partial refund in Upwork for the overpayment - apols!

@laurenreidexpensify
Copy link
Contributor

This is a new feature but doesn't require regression testing. Closing.

@github-project-automation github-project-automation bot moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collect May 29, 2024
@s77rt
Copy link
Contributor

s77rt commented May 29, 2024

@laurenreidexpensify Refunded! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
No open projects
Archived in project
Development

No branches or pull requests

6 participants