Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wave Collect] [Xero] [Advanced] Create the Bill Payment Account Selector Page #39751

Closed
lakchote opened this issue Apr 5, 2024 · 16 comments
Closed
Assignees
Labels
Daily KSv2 NewFeature Something to build that is a new item.

Comments

@lakchote
Copy link
Contributor

lakchote commented Apr 5, 2024

You need to build the page following the steps outlined here.

This will be worked on by SWM engineers, see Slack discussion here.

Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet.

@lakchote lakchote added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 5, 2024
@lakchote lakchote moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
@miljakljajic
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@SzymczakJ
Copy link
Contributor

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

@miljakljajic
Copy link
Contributor

Thank you @SzymczakJ :)

@lakchote lakchote changed the title [Wave Collect] [Xero] [Advanced] Create the Bill Payment Account Selector Page [HOLD #39746] [Wave Collect] [Xero] [Advanced] Create the Bill Payment Account Selector Page Apr 15, 2024
@trjExpensify trjExpensify moved this from Release 1: Spring 2024 (May) to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect Apr 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 23, 2024
@miljakljajic
Copy link
Contributor

How we doing on this @SzymczakJ

@melvin-bot melvin-bot bot removed the Overdue label Apr 24, 2024
@SzymczakJ
Copy link
Contributor

I'm implementing Advanced settings page along with this Bill Payment Account Selector Page. I'll be OOO next week but I will try to put out a draft PR for this today 😃

@mananjadhav
Copy link
Collaborator

I am working on this one. (slack thread)

Copy link

melvin-bot bot commented May 7, 2024

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Copy link

melvin-bot bot commented May 7, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@pecanoro
Copy link
Contributor

pecanoro commented May 9, 2024

Reassigning since @lakchote and I ended up reviewing the associated PR.

@pecanoro pecanoro assigned pecanoro and lakchote and unassigned madmax330 May 9, 2024
@trjExpensify
Copy link
Contributor

Merged into the Xero branch

@trjExpensify trjExpensify changed the title [HOLD #39746] [Wave Collect] [Xero] [Advanced] Create the Bill Payment Account Selector Page [Wave Collect] [Xero] [Advanced] Create the Bill Payment Account Selector Page May 16, 2024
@trjExpensify
Copy link
Contributor

Deployed to staging yesterday.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jun 3, 2024
Copy link

melvin-bot bot commented Jun 3, 2024

This issue has not been updated in over 15 days. @pecanoro, @lakchote, @miljakljajic, @SzymczakJ eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@pecanoro
Copy link
Contributor

pecanoro commented Jun 4, 2024

Do we need to pay @mananjadhav here before closing?

@pecanoro pecanoro added Hourly KSv2 Daily KSv2 and removed Monthly KSv2 Hourly KSv2 Reviewing Has a PR in review labels Jun 4, 2024
@hungvu193
Copy link
Contributor

I think No. We will be paid centrally when Xero project's done

@pecanoro
Copy link
Contributor

pecanoro commented Jun 4, 2024

Closing then!

@pecanoro pecanoro closed this as completed Jun 4, 2024
@github-project-automation github-project-automation bot moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collect Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

8 participants