[HOLD for payment 2024-06-11] [$250] Tapping outside quickly after clear status leads the user going back to the report screen #39848

m-natarajan · 2024-04-08T18:57:40Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.4.61-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712306439703269

Action Performed:

Go to Settings > Profile > Status
Change the status and save
Tapping status again
Click on clear status
Tapping outside quickly and notice

Expected Result:

The user should keep the side on the profile page

Actual Result:

The user goes back to report screen

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Recording.2953.mp4

Screen.Recording.2024-04-05.at.15.35.03.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014d6d259b4d3f1b08
Upwork Job ID: 1777489376165974016
Last Price Increase: 2024-04-09
Automatic offers:

GandalfGwaihir | Contributor | 0
nkdengineer | Contributor | 0

Issue Owner

Current Issue Owner: @jliexpensify

melvin-bot · 2024-04-08T18:57:51Z

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

FitseTLT · 2024-04-08T19:31:28Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping outside quickly after clear status leads the user going back to the report screen

What is the root cause of that problem?

B/c we are navigating back here after interaction

App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx

Lines 109 to 110 in ec41a4b

    
           InteractionManager.runAfterInteractions(() => { 
        
               navigateBackToPreviousScreen();

when we quickly dismiss modal then it will run goBack on that route opening the report screen instead of the intended dismissing of the status modal

What changes do you think we should make in order to solve the problem?

we should use dismissModal instead of goBack

            Navigation.dismissModal();

Also apply same change here

App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx

Lines 94 to 95 in ec41a4b

    
               navigateBackToPreviousScreen(); 
        
           });

What alternative solutions did you explore? (Optional)

We can also remove the runAfterInteraction and make the navigation happen immediately

jliexpensify · 2024-04-09T00:10:57Z

Interesting, I can repro but it doesn't take me to a Report - instead I get taken to my Profile screen. Also on v1.4.61-0

melvin-bot · 2024-04-09T00:11:07Z

Job added to Upwork: https://www.upwork.com/jobs/~014d6d259b4d3f1b08

melvin-bot · 2024-04-09T00:11:12Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

jliexpensify · 2024-04-09T00:14:25Z

I also think this shoudl go in #vip-vsb as it deals with Chat Functionality

allgandalf · 2024-04-09T00:45:32Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are navigated to the last navigated route before profile if we dismiss model quickly after clearing status

What is the root cause of that problem?

When we call clearStatus after the action is performed it will call navigateBackToPreviousScreen which will call the goBack funciton:

App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx

Line 77 in ec41a4b

    
           const navigateBackToPreviousScreen = useCallback(() => Navigation.goBack(), []);

Now if we have already dismissed the RHP this will take us back to the last accessed route, it can be security tab/preferences/workspaces anything last visited and not limited to reports.

What changes do you think we should make in order to solve the problem?

We can take help of the isDisplayedInModal function from Navigation:

App/src/libs/Navigation/Navigation.ts

Lines 354 to 355 in ec41a4b

    
           /** Check if the modal is being displayed */ 
        
           function isDisplayedInModal() {

This will help us to Check if the modal is being displayed, if the modal is still displayed then we will call the navigateBackToPreviousScreen function, if not then we won't call the function, this will also help us avoid unnecessary function calls to navigateBackToPreviousScreen, so if the Modal/RHP is open then only we will call the goBack function , otherwise we can simply end the function over there and not execute navigateBackToPreviousScreen.

diff --git a/src/pages/settings/Profile/CustomStatus/StatusPage.tsx b/src/pages/settings/Profile/CustomStatus/StatusPage.tsx
index bb7be4a686..0912e610e7 100644
--- a/src/pages/settings/Profile/CustomStatus/StatusPage.tsx
+++ b/src/pages/settings/Profile/CustomStatus/StatusPage.tsx
@@ -107,7 +107,9 @@ function StatusPage({draftStatus, currentUserPersonalDetails}: StatusPageProps)
         formRef.current?.resetForm({[INPUT_IDS.EMOJI_CODE]: ''});
 
         InteractionManager.runAfterInteractions(() => {
-            navigateBackToPreviousScreen();
+            if (Navigation.isDisplayedInModal()) {
+                navigateBackToPreviousScreen();
+            }
         });
     };

What alternative solutions did you explore? (Optional)

N/A

nkdengineer · 2024-04-09T02:00:52Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user goes back to report screen

What is the root cause of that problem?

When we save or clear status, we call goBack function after interaction here. So if we tapping outside quickly before this function is called, we will go back to previous screen which is report screen in this case.

App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx

Lines 109 to 111 in 76c7fa9

    
           InteractionManager.runAfterInteractions(() => { 
        
               navigateBackToPreviousScreen(); 
        
           });

What changes do you think we should make in order to solve the problem?

We should cancel the interaction task if it's not called before the StatusPage is unmounted. That will make sure that we will not do the interaction task if this page is already unmounted.

Create a navigateBackToPreviousScreenTask ref

const navigateBackToPreviousScreenTask = useRef<{
    then: (onfulfilled?: () => any, onrejected?: () => any) => Promise<any>;
    done: (...args: any[]) => any;
    cancel: () => void;
} | null>(null);

Assign this ref to the interaction task

navigateBackToPreviousScreenTask.current = InteractionManager.runAfterInteractions(() => {
    navigateBackToPreviousScreen();
});

App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx

Line 109 in 76c7fa9

InteractionManager.runAfterInteractions(() => {

App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx

Line 93 in 76c7fa9

InteractionManager.runAfterInteractions(() => {

Cancel the task if the component is unmounted

useEffect(() => {
    return () => {
        if (!navigateBackToPreviousScreenTask.current) {
            return;
        }

        navigateBackToPreviousScreenTask.current.cancel();
    }
}, [])

What alternative solutions did you explore? (Optional)

NA

dukenv0307 · 2024-04-09T02:38:57Z

@jliexpensify I'm the reporter of this issue, I can take over this as C+.

jliexpensify · 2024-04-10T02:56:05Z

Hi @dukenv0307 - for fairness sake, I think it would be good to keep this with the auto-assigner. We currently don't have a documented process for what happens if a C+ reports a bug and wishes to be assigned - if you feel that the C+ who reports a bug should be the one assigned, you can present a Problem/Solution statement in #contributor-plus for review by our team and we can add it to our documentation, if we agree.

Also bumping @thesahindia for reviews!

jliexpensify · 2024-04-12T02:20:36Z

Bumped @thesahindia on Slack, please review. If you're not able to take this on, I'll re-assign the issue.

thesahindia · 2024-04-12T14:57:38Z

@GandalfGwaihir's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

melvin-bot · 2024-04-12T14:57:51Z

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot · 2024-04-12T15:03:41Z

📣 @GandalfGwaihir 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

nkdengineer · 2024-04-12T15:41:52Z

@thesahindia The proposal from @GandalfGwaihir will not correct in this case we clear the status and open quickly any modal by shortcut keyboard like Search page or Short cut modal like this video (I applied the selected solution in this video). We should cancel the interaction task when the component is unmounted that will make sure we will do nothing if the component is unmounted before the interaction task is executed.

cc @youssef-lr

Screen.Recording.2024-04-12.at.22.40.52.mov

youssef-lr · 2024-04-12T15:48:03Z

Honestly, I'm not sure this is bug is worth fixing right now, how likely is this to be an issue for real world users? cc @jliexpensify

youssef-lr · 2024-04-12T15:51:15Z

@GandalfGwaihir let's hold off on working on this until we're sure we want to fix this.

nkdengineer · 2024-04-12T16:05:51Z

@youssef-lr Since the solution to fix all possible cases is very simple, I think we can fix all of this to not face other bugs like this in the further.

allgandalf · 2024-04-12T16:06:03Z

@youssef-lr yeah sure, my branch is ready for PR, let me know once we decide to fix this

melvin-bot · 2024-06-04T13:53:31Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-06-04T13:53:37Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[Fix]: Tapping outside quickly after clear status leads the user going back to the report screen #40364

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

@thesahindia requires payment through NewDot Manual Requests
@allgandalf requires payment (Needs manual offer from BZ)
@nkdengineer requires payment automatic offer (Contributor)
@dukenv0307 requires payment (Needs manual offer from BZ)

melvin-bot · 2024-06-04T13:53:38Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@thesahindia / @allgandalf] The PR that introduced the bug has been identified. Link to the PR:
[@thesahindia / @allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia / @allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@thesahindia / @allgandalf] Determine if we should create a regression test for this bug.
[@thesahindia / @allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

jliexpensify · 2024-06-05T00:17:07Z

New summary, is this correct?

C: @allgandalf $125
C: @nkdengineer $125
C+: @thesahindia $250 (ND request)

Upwork job

dukenv0307 · 2024-06-05T02:56:08Z

@jliexpensify I think there's a confusion here. I'm a reporter not C+. Should I get paid? Thanks

jliexpensify · 2024-06-05T03:28:07Z

Aha sorry - I was going off this

Hmm, I don't think we pay out bug reporting anymore but let me double-check.

Asking internally - https://expensify.slack.com/archives/C01SKUP7QR0/p1717558475261729

jliexpensify · 2024-06-05T09:51:42Z

So we don't pay on bug reporting anymore @dukenv0307 - not sure why Melvin is including you. Apologies!

thesahindia · 2024-06-05T10:30:08Z

It was a really minor issue which couldn't have been prevented. Also we don't need a test case here.

youssef-lr · 2024-06-12T17:40:30Z

Not overdue

jliexpensify · 2024-06-12T21:52:51Z

Ah sorry, I missed this one yesterday. Paying today!

@thesahindia and @allgandalf - is there a checklist that needs to be done?

jliexpensify · 2024-06-13T02:13:08Z

Whoops sorry, ignore me - no checklist needed.

jliexpensify · 2024-06-13T02:15:51Z

Damn, job is expired. @allgandalf and @nkdengineer - can you accept the offers here?

allgandalf · 2024-06-13T03:23:37Z

accepted @jliexpensify 👍

jliexpensify · 2024-06-13T10:44:23Z

Cheers, just waiting on @nkdengineer

nkdengineer · 2024-06-13T16:50:38Z

Sorry @jliexpensify I don't have any Upwork Connects left so could not apply to the job. Would you mind sending the offer directly to my Upwork profile?

TIA!

jliexpensify · 2024-06-14T00:02:18Z

@nkdengineer I sent you an offer yesterday, can you see / accept this?

nkdengineer · 2024-06-14T17:12:52Z

@jliexpensify Yes I accepted, thanks

jliexpensify · 2024-06-16T22:58:42Z

Everyone is paid, and the job is closed! @thesahindia and JMills, please refer to this summary for ND payments.

JmillsExpensify · 2024-06-18T18:09:22Z

$250 approved for @thesahindia

m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 8, 2024

melvin-bot bot assigned jliexpensify Apr 8, 2024

jliexpensify added the External Added to denote the issue can be worked on by a contributor label Apr 9, 2024

melvin-bot bot changed the title ~~Tapping outside quickly after clear status leads the user going back to the report screen~~ [$250] Tapping outside quickly after clear status leads the user going back to the report screen Apr 9, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 9, 2024

melvin-bot bot assigned thesahindia Apr 9, 2024

jliexpensify added this to [#whatsnext] #vip-vsb Apr 9, 2024

melvin-bot bot assigned youssef-lr Apr 12, 2024

youssef-lr assigned allgandalf Apr 12, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 12, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Jun 4, 2024

melvin-bot bot changed the title ~~[$250] Tapping outside quickly after clear status leads the user going back to the report screen~~ [HOLD for payment 2024-06-11] [$250] Tapping outside quickly after clear status leads the user going back to the report screen Jun 4, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Jun 4, 2024

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 10, 2024

youssef-lr removed the Overdue label Jun 12, 2024

melvin-bot bot added the Overdue label Jun 12, 2024

melvin-bot bot removed the Overdue label Jun 12, 2024

jliexpensify closed this as completed Jun 16, 2024

[HOLD for payment 2024-06-11] [$250] Tapping outside quickly after clear status leads the user going back to the report screen #39848

[HOLD for payment 2024-06-11] [$250] Tapping outside quickly after clear status leads the user going back to the report screen #39848

Comments

m-natarajan commented Apr 8, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Apr 8, 2024

FitseTLT commented Apr 8, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

jliexpensify commented Apr 9, 2024

melvin-bot bot commented Apr 9, 2024

melvin-bot bot commented Apr 9, 2024

jliexpensify commented Apr 9, 2024

allgandalf commented Apr 9, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

nkdengineer commented Apr 9, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dukenv0307 commented Apr 9, 2024

jliexpensify commented Apr 10, 2024

jliexpensify commented Apr 12, 2024

thesahindia commented Apr 12, 2024

melvin-bot bot commented Apr 12, 2024

melvin-bot bot commented Apr 12, 2024

nkdengineer commented Apr 12, 2024

youssef-lr commented Apr 12, 2024

youssef-lr commented Apr 12, 2024

nkdengineer commented Apr 12, 2024

allgandalf commented Apr 12, 2024 • edited Loading

melvin-bot bot commented Jun 4, 2024

melvin-bot bot commented Jun 4, 2024

melvin-bot bot commented Jun 4, 2024

jliexpensify commented Jun 5, 2024 • edited Loading

dukenv0307 commented Jun 5, 2024

jliexpensify commented Jun 5, 2024 • edited Loading

jliexpensify commented Jun 5, 2024

thesahindia commented Jun 5, 2024

youssef-lr commented Jun 12, 2024

jliexpensify commented Jun 12, 2024

jliexpensify commented Jun 13, 2024

jliexpensify commented Jun 13, 2024

allgandalf commented Jun 13, 2024

jliexpensify commented Jun 13, 2024

nkdengineer commented Jun 13, 2024

jliexpensify commented Jun 14, 2024

nkdengineer commented Jun 14, 2024

jliexpensify commented Jun 16, 2024

JmillsExpensify commented Jun 18, 2024

m-natarajan commented Apr 8, 2024 •

edited by melvin-bot bot

Loading

nkdengineer commented Apr 9, 2024 •

edited

Loading

allgandalf commented Apr 12, 2024 •

edited

Loading

jliexpensify commented Jun 5, 2024 •

edited

Loading

jliexpensify commented Jun 5, 2024 •

edited

Loading