Android/iOS - Shortcut - Tapping shortcut track manual does not trigger any action

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.61
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Launch app
2. Tap fab--- track expense---manual
3. Enter an amount and tap next
4. Tap track expense
5. Navigate back to LHN
6. Tap fab
7. Tap shortcut track manual

Expected Result:

Tapping shortcut track manual must direct to track manual page

Actual Result:

Tapping shortcut track manual does not trigger any action

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442458_1712590087801.dp.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens when we click on Track expense shortcut

What is the root cause of that problem?

This is reproducible in all platforms not just android.

We do not have case defined for track expense in navigateToQuickAction

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Line 175 in 89b9cef

const navigateToQuickAction = () => {

Here we do not have the startMoneyRequest action defined for CONST.QUICK_ACTIONS.TRACK_MANUAL, and hence it will return a empty string which is its default value:

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Lines 201 to 203 in 89b9cef

	default:
	return '';
	}

So it returns default value as empty string.

What changes do you think we should make in order to solve the problem?

We need to define the case for track expense shortcut:

            case CONST.QUICK_ACTIONS.TRACK_MANUAL:
                IOU.startMoneyRequest(CONST.IOU.TYPE.TRACK_EXPENSE, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.MANUAL);
                return;

This will route the user to track expense page through the shortcut.

What alternative solutions did you explore? (Optional)

N/A

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Shortcut - Tapping shortcut track manual does not trigger any action

What is the root cause of that problem?

The main problem with the issue is that in this PR we added some new actions #39149
but didn't add navigation logic for them

What changes do you think we should make in order to solve the problem?

To fix this issue we can update our navigateToQuickAction and add some new actions related with TRACK_EXPENSE

            case CONST.QUICK_ACTIONS.TRACK_MANUAL:
                IOU.startMoneyRequest(CONST.IOU.TYPE.TRACK_EXPENSE, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.MANUAL);
                return;
            case CONST.QUICK_ACTIONS.TRACK_SCAN:
                IOU.startMoneyRequest(CONST.IOU.TYPE.TRACK_EXPENSE, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.SCAN);
                return;
            case CONST.QUICK_ACTIONS.TRACK_DISTANCE:
                IOU.startMoneyRequest(CONST.IOU.TYPE.TRACK_EXPENSE, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.DISTANCE);
                return;

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Lines 175 to 203 in 9adb9ef

	const navigateToQuickAction = () => {
	switch (props.quickAction.action) {
	case CONST.QUICK_ACTIONS.REQUEST_MANUAL:
	IOU.startMoneyRequest(CONST.IOU.TYPE.REQUEST, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.MANUAL);
	return;
	case CONST.QUICK_ACTIONS.REQUEST_SCAN:
	IOU.startMoneyRequest(CONST.IOU.TYPE.REQUEST, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.SCAN);
	return;
	case CONST.QUICK_ACTIONS.REQUEST_DISTANCE:
	IOU.startMoneyRequest(CONST.IOU.TYPE.REQUEST, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.DISTANCE);
	return;
	case CONST.QUICK_ACTIONS.SPLIT_MANUAL:
	IOU.startMoneyRequest(CONST.IOU.TYPE.SPLIT, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.MANUAL);
	return;
	case CONST.QUICK_ACTIONS.SPLIT_SCAN:
	IOU.startMoneyRequest(CONST.IOU.TYPE.SPLIT, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.SCAN);
	return;
	case CONST.QUICK_ACTIONS.SPLIT_DISTANCE:
	IOU.startMoneyRequest(CONST.IOU.TYPE.SPLIT, props.quickAction.chatReportID, CONST.IOU.REQUEST_TYPE.DISTANCE);
	return;
	case CONST.QUICK_ACTIONS.SEND_MONEY:
	IOU.startMoneyRequest(CONST.IOU.TYPE.SEND, props.quickAction.chatReportID);
	return;
	case CONST.QUICK_ACTIONS.ASSIGN_TASK:
	Task.clearOutTaskInfoAndNavigate(props.quickAction.chatReportID, quickActionReport, _.get(props.quickAction, 'targetAccountID', 0));
	return;
	default:
	return '';
	}

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

cc @thienlnam

[muttmuure]

Posted ere: https://expensify.slack.com/archives/C066HJM2CAZ/p1713201165427219

[allgandalf]

isn't this going to be external ? @muttmuure , similar issue related to track manual is external already: #40097

[muttmuure]

@Gonals what's the plan with these?

https://github.com/Expensify/Expensify/issues/378892

[Gonals]

This was expected, as track functionality wasn't implemented yet. This PRshould fix this, so I'm going to close 😁