[$250] Request Money - Inconsistent Padding Between Error Message and Save Button in Tax value section

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1,Navigate to Profile > Workspace > Create Workspace.
2, Enable tax feature under More Features > Tax Rate 1.
3, Go to the Value section, clear the number, and attempt to save. Observe the padding between the save button and the error message.
4, Access FAB > Request Money > Add Amount > Choose Split With.
5, Proceed to the Tax Amount section and attempt to save without entering anything. Note the padding between the error message and the save button.
6, The padding between the error message and the save button in the Tax Value section and Tax Amount section is inconsistent.

Expected Result:

The padding between the error message and the save button in the Tax Value section should be consistent with other number value sections.

Actual Result:

The padding between the error message and the save button in the Tax Value section increases significantly and is inconsistent with other number value sections.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6443310_1712659066045.Screen_Recording_2024-04-09_at_3.32.38_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d37ed51248fa5380
• Upwork Job ID: 1777812961038524416
• Last Price Increase: 2024-04-09
• Automatic offers:
• hungvu193 | Reviewer | 0
• Krishna2323 | Contributor | 0

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

We think this issue might be related to the #collect project.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request Money - Inconsistent Padding Between Error Message and Save Button in Tax value section

What is the root cause of that problem?

We haven't added styles.mt0 to submitButtonStyles in ValuePage.

App/src/pages/workspace/taxes/ValuePage.tsx

Line 85 in 4f67357

submitButtonStyles={[styles.mh5]}

What changes do you think we should make in order to solve the problem?

We need to just pass styles.mt0 to submitButtonStyles and it will fix the issue.

We use always pass styles.mt0 when we use AmountForm in other components.

App/src/pages/workspace/distanceRates/CreateDistanceRatePage.tsx

Lines 85 to 89 in 4f67357

	submitButtonStyles={[styles.mh5, styles.mt0]}
	disablePressOnEnter={false}
	>
	<InputWrapperWithRef
	InputComponent={AmountForm}

App/src/pages/workspace/distanceRates/PolicyDistanceRateEditPage.tsx

Lines 86 to 90 in 4f67357

	submitButtonStyles={[styles.mh5, styles.mt0]}
	disablePressOnEnter={false}
	>
	<InputWrapperWithRef
	InputComponent={AmountForm}

App/src/pages/workspace/reimburse/WorkspaceRateAndUnitPage/RatePage.tsx

Lines 81 to 85 in 4f67357

	submitButtonStyles={[styles.mh5, styles.mt0]}
	disablePressOnEnter={false}
	>
	<InputWrapperWithRef
	InputComponent={AmountForm}

What alternative solutions did you explore? (Optional)

[Krishna2323]

Proposal Updated

• Added references

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d37ed51248fa5380

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

@Krishna2323's proposal here is straightforward and looks good to me
🎀 👀 🎀 C+ reviewed

[hungvu193]

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[lakchote]

@Krishna2323's proposal LGTM

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[hungvu193]

@Krishna2323 do you have any ETA for the PR?

[Krishna2323]

@hungvu193, PR is ready for video, only the recording for android native is remaining, there are some build issues.

[hungvu193]

@hungvu193, PR is ready for video, only the recording for android native is remaining, there are some build issues.

Cool. That's fine because Android build is failing after new arch was enable, can you check all checklist please?

[Krishna2323]

@hungvu193, done!

[Krishna2323]

@MitchExpensify, PR was deployed to production on 22nd April, this is ready for the payments process.

[MitchExpensify]

Payment summary:

C $250 @Krishna2323
C+ $250 @hungvu193

[melvin-bot]

This issue has not been updated in over 15 days. @hungvu193, @lakchote, @MitchExpensify, @Krishna2323 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[hungvu193]

We're good to close this one ☝️