[HOLD for payment 2024-05-02] [Guided Setup] [Hold #39687] Web - Onboarding - highlight shows up around onboarding video when clicking volume button

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.61-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Navigate to settings > About > Troubleshoot
3. Click on "Navigate" on "Onboarding Flow"
4. Input first name and last name
5. Click on "Continue"
6. Select a purpose and click on "Continue"
7. Click on the video to pause it and click on it again to play the video
8. Press on volume up and down buttons on keyboard

Expected Result:

No highlight should be visible around the video

Actual Result:

A highlight around the video becomes visible

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6443370_1712663660654.bandicam_2024-04-09_14-47-36-759.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[ghost]

This issue is not available until esc key is pressed.

Screen.Recording.2024-04-09.at.6.47.19.PM.mp4

cc - @youssef-lr @kbecciv

[mountiny]

Not a blocker as this is not accessible for the new users, I am helping with this project now so taking over

[cdOut]

Hi, I'm Tymoteusz from Software Mansion, the expert agency, and I will work on this issue.

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[cdOut]

@mountiny First of all this is not an issue with Onboarding itself, this exact bug also happens for every video attachment. I have fixed this styling issue in this onboarding enable PR.

[trjExpensify]

Put this on hold for that PR, once deployed the fix can be verified and then this issue closed.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Onboarding - Stage 2] Onboarding Flow - enabled #39687

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

• @cdOut does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@cdOut] Determine if we should create a regression test for this bug.
• [@cdOut] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

Payment Summary

No external contractors engaged so no payments necessary