Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-04-10 #40026

Closed
github-actions bot opened this issue Apr 10, 2024 · 25 comments
Closed

Deploy Checklist: New Expensify 2024-04-10 #40026

github-actions bot opened this issue Apr 10, 2024 · 25 comments
Assignees
Labels
Hourly KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024

Release Version: 1.4.62-17
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@Julesssss Julesssss added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 10, 2024
@Julesssss Julesssss assigned Julesssss and unassigned Julesssss Apr 10, 2024
@kavimuru
Copy link

Checking off the PROD PRs (help.expensify.com)
#39387
#39664
#39666
#39667
#39669
#39826

@blimpich
Copy link
Contributor

Demoting #40027

@roryabraham
Copy link
Contributor

#40050 is intended behavior

@Julesssss
Copy link
Contributor

#40082 is not a blocker
#39982 is not a blocker
#40052 is not a blocker

@twisterdotcom
Copy link
Contributor

Closed #40093

@Julesssss
Copy link
Contributor

#40053 is minor and related to a new feature (live-markdown)
#40086 is a console log, demoted

@Julesssss
Copy link
Contributor

Julesssss commented Apr 11, 2024

#40085 demoted as not critical

@Julesssss
Copy link
Contributor

#40067
and #40029 fixed by this CP: #40079

@Julesssss
Copy link
Contributor

#40036 fixed by #40049

@kavimuru
Copy link

Regression is 3% left.
#38730 failing with #40103
#38947 failing with #40048
#39190 failing with #40029
#39239 failing with #40043
#39372 failing with #40041
#39723 failing with #40051 repro in PROD, checking it off
#39788 failing with #40052

@Beamanator
Copy link
Contributor

Checked off #40081 as it doesn't seem like a big enough issue to be a blocker

@Julesssss
Copy link
Contributor

#40055 fixed by #40096

@luacmartins
Copy link
Contributor

Demoted #40126

@deetergp
Copy link
Contributor

Demoted #40035

@kavimuru
Copy link

Regression is just 14 steps left.
Unchecked PRs:
#39394 we need more details about the QA steps and not sure it is internal. Comment
#38730 failing with #40103
#38947 failing with #40048
#39190 failing with #40029
#39239 failing with #40043
#39372 failing with #40041
#39454 failing with #40108
#39562 failing with #40036
#39788 failing with #40052

@kavimuru
Copy link

Regression is completed.
Unchecked PRs:
#39394 we need more details about the QA steps and not sure it is internal. Comment
#38730 failing with #40103
#38947 failing with #40048
#39190 failing with #40029
#39239 failing with #40043
#39372 failing with #40041
#39454 failing with #40108
#39562 failing with #40036
#39788 failing with #40052
Open Blockers:
#40034
#40037
#40040
#40041
#40048
#40057
#40076
#40077
#40078
#40084
#40087
#40105
#40107
#40108
#40123
#40124

@rlinoz
Copy link
Contributor

rlinoz commented Apr 11, 2024

Demoting #40105

@Beamanator
Copy link
Contributor

This CP'd PR fixed #40080, both are checked off the list now

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 15, 2024
@roryabraham roryabraham added Hourly KSv2 and removed Monthly KSv2 labels Apr 15, 2024
@roryabraham
Copy link
Contributor

confirmed #40077 is fixed, checking it off

@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2024
@roryabraham
Copy link
Contributor

ok, so we've been talking through this checklist in #fireroom-2024-04-17-app-deploy. Ultimately it has not gone very smoothly, and that's largely due to inconsistently reproducible but critical issues that have happened in concert with enabling the new architecture.

Our plan is to ship this release on all platforms except Android, where we're aware of a number of unresolved critical issues. This will allow us to continue shipping code on all other platforms and prevent the monster release that will follow this one from growing any more cumbersome than it already promises to be.

@roryabraham
Copy link
Contributor

#40360 is fixed by #40383 in 1.4.62-15 (without re-introducing #40077)

@roryabraham
Copy link
Contributor

#40048 and #40108 share the same root cause, and remain unresolved. These are Android-only issues, and as mentioned above I'm going to check them off. They will continue to have the deploy blocker label, so should appear as deploy blockers in the next checklist

@thienlnam
Copy link
Contributor

There's only one fresh crash
SensorSetter.sensorSetter

Fatal Exception: com.facebook.jni.CppException
Exception in HostFunction: Error: Exception in HostFunction: at _maybeFlushUIUpdatesQueue (native) at anonymous (JavaScript:1:405) at callMicrotasksOnUIThread (JavaScript:1:61) at anonymous (JavaScript:1:406)

com.swmansion.reanimated.nativeProxy.SensorSetter.sensorSetter (SensorSetter.java)

It's only happened to a single user on 1.4.62-7 so I think we're okay here -

@thienlnam
Copy link
Contributor

:shipit:

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hourly KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests