[HOLD for payment 2024-06-28] [$250] Group Chat custom avatar not saved when navigating back to invite members page

[marcaaron]

Coming from #39757 (comment)

1. Create a new group chat
2. Choose a picture for custom avatar
3. Go back to member invite page
4. Proceed again
5. Create chat

Expected:

Avatar image should be saved.

Actual

Picture is not taken into consideration.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014f246ab8eb2607ee
• Upwork Job ID: 1785758481083801600
• Last Price Increase: 2024-06-05
• Automatic offers:
• s77rt | Reviewer | 102700850
• wildan-m | Contributor | 102700854

Issue Owner

Current Issue Owner: @adelekennedy

[marcaaron]

I am guessing this is because the file ref needs to be cached outside the component lifecycle or some other strategy to achieve it. Feels like a minor issue that can be easily solved.

[s77rt]

No progress yet. Focused on QBO

[marcaaron]

Gonna take this one External so we can make some progress.

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014f246ab8eb2607ee

[melvin-bot]

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group Chat custom avatar not saved when navigating back to invite members page

What is the root cause of that problem?

When creating the group, we use the outdated fileRef.current which is undefined when coming back.

App/src/pages/NewChatConfirmPage.tsx

Line 96 in 406139c

Report.navigateToAndOpenReport(logins, true, newGroupDraft.reportName ?? '', newGroupDraft.avatarUri ?? '', fileRef.current, optimisticReportID.current);

What changes do you think we should make in order to solve the problem?

We should use stashedLocalAvatarImage which takes the saved picture from the NEW_GROUP_CHAT_DRAFT Onyx key when creating the groupChat

App/src/pages/NewChatConfirmPage.tsx

Line 107 in 406139c

const stashedLocalAvatarImage = newGroupDraft?.avatarUri;

[s77rt]

@neonbhai Thanks for the proposal. Your RCA makes sense but the solution won't work. In onyx we only store the url and we want to pass the whole image.

[s77rt]

Still looking for proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[adelekennedy]

still waiting for proposals - @marcaaron @s77rt is this a more complex issue than originally thought?

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[wildan-m]

@MonilBhavsar, do we need to consider anything else before we proceed?

[MonilBhavsar]

No thanks! looks good to me. Thanks for keeping it consistent with receipt scan flow

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @wildan-m 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[wildan-m]

@s77rt The PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix create group image lost when modify member #43584

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @wildan-m requires payment automatic offer (Contributor)
• @s77rt requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: [Group Chats] Add remaining features #39757 (comment)
• The offending PR has been commented on : [Group Chats] Add remaining features #39757 (comment)
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: Yes

---

Regression Test Proposal

1. Click FAB > Start chat
2. Select multiple users (group) and press Next
3. Upload a group avatar
4. Go back
5. Click Next
6. Click Start group
7. Verify that the group is created and the custom avatar is used

[marcaaron]

LGTM

[adelekennedy]

Payouts due:

• Contributor: $250 @wildan-m
• Contributor+: $250 @s77rt

[adelekennedy]

https://github.com/Expensify/Expensify/issues/409492