[$250] [HOLD for payment 2024-06-11] Uploading a Group Chat custom avatar that is too large shows badly formatted error message

[marcaaron]

Coming from #39757 (comment)

Reproduction:

1. Create a Group Chat
2. Navigate to report details page
3. Upload a custom avatar that is too large

Expected:

The error message displayed is taking up the normal width of the screen.

Actual:

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013621cec02e1951b1
• Upwork Job ID: 1800948188003727972
• Last Price Increase: 2024-06-12

Issue Owner

Current Issue Owner: @

[s77rt]

@Expensify/design I found this inconsistency in the avatar error message, which one is the correct one?

[shawnborton]

Hmm I think I lean towards the right version being more correct. Thoughts @Expensify/design?

[dannymcclain]

Yeah I think so too. I think it makes more sense with the rest of our app for it to span the full width.

[s77rt]

Working on a similar issue on #42088 (comment). Checking if we can fix that issue there too

[s77rt]

Just raised a PR

[c3024]

@marcaaron Can you please assign me this issue as C+ as I reviewed the PR?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix AvatarWithImagePicker error styles #42735

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment (Needs manual offer from BZ)
• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @laurenreidexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @s77rt paid $(AMOUNT) via Upwork (LINK)
• ROLE: @c3024 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@laurenreidexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013621cec02e1951b1

[melvin-bot]

Current assignees @s77rt and @c3024 are eligible for the External assigner, not assigning anyone new.

[laurenreidexpensify]

@s77rt @c3024 pls apply in upwork thanks - https://www.upwork.com/jobs/~013621cec02e1951b1

[s77rt]

@laurenreidexpensify Accepted! Thanks!

[c3024]

@laurenreidexpensify applied, thank you.

[laurenreidexpensify]

Summary:

• C+ @s77rt paid $250 via Upwork
• Contributor @c3024 paid $250 via Upwork

@s77rt regression step recommendations for this?

[s77rt]

@laurenreidexpensify The bug was found during PR review and not entirely a regression. I don't think this is worth adding a test for