[HOLD for payment 2024-05-20] [$250] Skeleton loader uses lighter color for page header

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.62-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713166267469379

Action Performed:

1. Open a chat which will show a skeleton loader
2. Look at the header of the chat report

Expected Result:

The skeleton loader for the top page/chat header should use the same color background as the skeleton loader for the chat messages in the main content screen.

Actual Result:

The skeleton loader used in the top page/chat header is using slightly lighter colors

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0199d049e1997c5cb7
• Upwork Job ID: 1779899140122308608
• Last Price Increase: 2024-04-15
• Automatic offers:
• abdulrahuman5196 | Reviewer | 0
• GandalfGwaihir | Contributor | 0

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Loading lines colour of header and report doesn't match

What is the root cause of that problem?

Currently we have the lines colour as theme.highlightBG this gives us faint lines

App/src/components/ReportHeaderSkeletonView.tsx

Lines 47 to 53 in 1cb6e00

	<SkeletonViewContentLoader
	animate={shouldAnimate}
	width={styles.w100.width}
	height={height}
	backgroundColor={theme.highlightBG}
	foregroundColor={theme.border}
	>

What changes do you think we should make in order to solve the problem?

We need to use skeletonLHNIn as bg colour and theme.skeletonLHNOut as foreground colour.

We do the same for report screen:

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.tsx

Lines 18 to 24 in 1cb6e00

	<SkeletonViewContentLoader
	animate={shouldAnimate}
	height={CONST.CHAT_SKELETON_VIEW.HEIGHT_FOR_ROW_COUNT[numberOfRows]}
	backgroundColor={theme.skeletonLHNIn}
	foregroundColor={theme.skeletonLHNOut}
	style={styles.mr5}
	>

The colour of these styles for dark mode is :

App/src/styles/theme/themes/dark.ts

Lines 85 to 86 in 1cb6e00

	skeletonLHNIn: colors.productDark400,
	skeletonLHNOut: colors.productDark600,

And for light mode is:

App/src/styles/theme/themes/light.ts

Lines 85 to 86 in 1cb6e00

	skeletonLHNIn: colors.productLight400,
	skeletonLHNOut: colors.productLight600,

This should make both the report as well as the report header consistent in loading colour

What alternative solutions did you explore? (Optional)

[twisterdotcom]

Ahh:

Issue reported by: @shawnborton

Gonna make external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0199d049e1997c5cb7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[mananjadhav]

I was too slow in posting a proposal. 🐌

[allgandalf]

I was too slow in posting a proposal. 🐌

😆 godspeed

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Skeleton loader uses lighter color for page header.

What is the root cause of that problem?

On the hedare we are using ReportHeaderSkeletonView for the loading animation
But on the report we use ReportActionsSkeletonView

Those boath components uses the same SkeletonViewContentLoader with different parameters
here:

App/src/components/ReportHeaderSkeletonView.tsx

Lines 47 to 52 in fdae0bd

	<SkeletonViewContentLoader
	animate={shouldAnimate}
	width={styles.w100.width}
	height={height}
	backgroundColor={theme.highlightBG}
	foregroundColor={theme.border}

and here:

App/src/components/ReportActionsSkeletonView/SkeletonViewLines.tsx

Lines 18 to 23 in fdae0bd

	<SkeletonViewContentLoader
	animate={shouldAnimate}
	height={CONST.CHAT_SKELETON_VIEW.HEIGHT_FOR_ROW_COUNT[numberOfRows]}
	backgroundColor={theme.skeletonLHNIn}
	foregroundColor={theme.skeletonLHNOut}
	style={styles.mr5}

Also there's an issue with the alignment of the animation

What changes do you think we should make in order to solve the problem?

1- to fix the colors:
we shoudl use the same backgroundColor and foregroundColor

backgroundColor={theme.skeletonLHNIn}
foregroundColor={theme.skeletonLHNOut}

2- align the header animation same as report animation
we should remove the padding left here

App/src/components/ReportHeaderSkeletonView.tsx

Line 33 in fdae0bd

<View style={[styles.appContentHeaderTitle, !isSmallScreenWidth && styles.pl5]}>

POC:

[dragnoir]

@shawnborton what devices did you use for the screenshot?

I noticed a bad alignment (more padding on the left) on the header skeleton on web

[AbrarAlHasan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent Color in Skeleton Loader header between the header and Main Content Screen

What is the root cause of that problem?

The Root cause of this Problem is due to the wrong Color used in the SkeltonViewContentLoader

What changes do you think we should make in order to solve the problem?

Changing the Color in the Skeleton Header to the color used in the Main content Screen will Solve this Problem.

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 @AbrarAlHasan! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[AbrarAlHasan]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01d42425e0d283e140

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[shawnborton]

I noticed a bad alignment (more padding on the left) on the header skeleton on web

@dragnoir this was on desktop. I agree, we should fix the alignment too. cc @twisterdotcom - I like @dragnoir 's proposal to fix both the colors and alignment.

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dragnoir You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[allgandalf]

@twisterdotcom , my main solution is still being used over here, shouldn’t i also be eligible for compensation here?

[twisterdotcom]

We could split this then @dragnoir? Given you're doing the work, how do we feel about 70/30?

• @dragnoir = $175
• @GandalfGwaihir = $75

[dragnoir]

@twisterdotcom perfect, thank you

[allgandalf]

@twisterdotcom , @shawnborton wait, there are two points here, the 2nd issue which @dragnoir mentioned doesn't exist, can you share the reproducible steps for the bug you identified @dragnoir :

Screen.Recording.2024-04-16.at.7.42.36.PM.mov

Secondly, if we implement the selected proposal to remove the padding altogether then there will be an regression for desktop app:

Screen.Recording.2024-04-16.at.7.47.24.PM.mov

[dragnoir]

@GandalfGwaihir adjust the isLoading state for HeaderView if you want to test.

20240416_152456.mp4

Don't worry, I will make sure no regressions on the PR.

[allgandalf]

friendly bump to @twisterdotcom for assignment as per @dragnoir's comments

[twisterdotcom]

Yes, happy to assign you. I know we've sort of circumvented @abdulrahuman5196 a bit but happy with Shawn's take from Design over an Internal engineer.

[melvin-bot]

📣 @GandalfGwaihir 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[allgandalf]

PR ready for review @abdulrahuman5196

[abdulrahuman5196]

Hi, Thank you. Will work on review.

[allgandalf]

friendly bump to @abdulrahuman5196 for review :)

[allgandalf]

friendly bump @abdulrahuman5196 for review, let's get this merged soon 🚀

[abdulrahuman5196]

Hi, Checking the PR now.

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[allgandalf]

Friendly bump for PR review @marcaaron

[allgandalf]

friendly bump @marcochavezf for PR review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix]: Foreground and Background of report header don't match with report view loading state #40534

If no regressions arise, payment will be issued on 2024-05-20. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment automatic offer (Reviewer)
• @GandalfGwaihir requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

Payment Summary:

• @abdulrahuman5196 paid $250 here (Reviewer)
• @GandalfGwaihir paid $250 here (Contributor)

I dont' think this was actually an introduced bug right, but it was actually a new feature. It never looked this way before right? We just got our greys wrong originally. I'm also not sure we can do regression testing for this?