Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QAB - Shortcut for manual request show as "Track expense" instead of "Track manual" #40554

Closed
1 of 6 tasks
kavimuru opened this issue Apr 19, 2024 · 6 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when validating #39640
Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com & log in
  2. Open the self-DM chat or WS chat
  3. Click + > Track Expense and follow the process to add a manual track expense
  4. Click + FAB icon & observe shortcut shown as "Track expense" instead of "Track manual"

Expected Result:

Shortcut for manual track expense should show as "Track manual" instead of "Track expense"

Actual Result:

Shortcut for manual track request show as "Track expense" instead of "Track manual"

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6454407_1713491834074!Screenshot__186_

Bug6454407_1713491834084.Recording__147.mp4

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 19, 2024
Copy link

melvin-bot bot commented Apr 19, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@kavimuru
Copy link
Author

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Apr 19, 2024

Looks like regression from this PR
fcfa4d4#diff-2a9066512656fa29b1565e362127de5cc11ba95b28f143a9db26f76dc3750785R605

Or it's expected

Proposal

Please re-state the problem that we are trying to solve in this issue.

QAB - Shortcut for manual request show as "Track expense" instead of "Track manual

What is the root cause of that problem?

The main problem with issue is that we have incorrect text for trackManual

What changes do you think we should make in order to solve the problem?

To fix this issue we can update this text

fcfa4d4#diff-2a9066512656fa29b1565e362127de5cc11ba95b28f143a9db26f76dc3750785R605

What alternative solutions did you explore? (Optional)

NA

@FitseTLT
Copy link
Contributor

FitseTLT commented Apr 19, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Shortcut for manual request show as "Track expense" instead of "Track manual"

What is the root cause of that problem?

Wrong text here

trackManual: 'Track expense',

What changes do you think we should make in order to solve the problem?

Change it to

        trackManual: 'Track manual',

What alternative solutions did you explore? (Optional)

@allgandalf
Copy link
Contributor

The result is expected, we changed the text here #40324

c.c. @mallenexpensify @Gonals

@mallenexpensify
Copy link
Contributor

Thanks @GandalfGwaihir , I've def been a lil tripped up this week with some of the updated around 'request money' to 'submit expense' and also 'track expense'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants