-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QAB - Shortcut for manual request show as "Track expense" instead of "Track manual" #40554
Comments
Triggered auto assignment to @mallenexpensify ( |
@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
Looks like regression from this PR Or it's expected ProposalPlease re-state the problem that we are trying to solve in this issue.QAB - Shortcut for manual request show as "Track expense" instead of "Track manual What is the root cause of that problem?The main problem with issue is that we have incorrect text for trackManual What changes do you think we should make in order to solve the problem?To fix this issue we can update this text fcfa4d4#diff-2a9066512656fa29b1565e362127de5cc11ba95b28f143a9db26f76dc3750785R605 What alternative solutions did you explore? (Optional)NA |
ProposalPlease re-state the problem that we are trying to solve in this issue.Shortcut for manual request show as "Track expense" instead of "Track manual" What is the root cause of that problem?Wrong text here Line 601 in 9b2c518
What changes do you think we should make in order to solve the problem?Change it to
What alternative solutions did you explore? (Optional) |
The result is expected, we changed the text here #40324 c.c. @mallenexpensify @Gonals |
Thanks @GandalfGwaihir , I've def been a lil tripped up this week with some of the updated around 'request money' to 'submit expense' and also 'track expense'. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when validating #39640
Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:
Expected Result:
Shortcut for manual track expense should show as "Track manual" instead of "Track expense"
Actual Result:
Shortcut for manual track request show as "Track expense" instead of "Track manual"
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6454407_1713491834084.Recording__147.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: