-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat - Mention containing valid report ID is not clickable and invalid # is not styled #40582
Comments
Triggered auto assignment to @jliexpensify ( |
We think that this bug might be related to #vip-vsb |
@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
Can't assign @robertKozik until he comments, but have assigned Puneet for this regression. |
Hi! Looking into it, thanks for pinging me here! |
I think we have a little misunderstanding there. User is able to mention rooms only by their names. ReportID values are embedded into HTML attributes of mention tag, and are done on the backend side. But I think we can be. more consistent while we are working on optimistic version of the message, as we will want to remove as much as possible jumping between highlighted -> non-highlighted states when getting the response from the backend. |
Yes, I think we can close. This is just a misunderstanding. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.63-7
Reproducible in staging?: y
Reproducible in production?: y
Issue found when executing PR: #39906
Reported: Applause - Internal Team
Action Performed:
Expected Result:
Actual Result:
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6454714_1713520407882.20240419_174807.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: