Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #40508] [$250] iOS - Chat - Contacts in the mention suggestion list overlap #40590

Closed
2 of 6 tasks
lanitochka17 opened this issue Apr 19, 2024 · 33 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to chat
  3. Type @
  4. Select a mention from the suggestion list
  5. Type @

Expected Result:

The content in the list will not overlap

Actual Result:

The content in the list overlaps

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453914_1713459839796.RPReplay_Final1713459683.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01754fc1f82dc0f2e2
  • Upwork Job ID: 1782542904959717376
  • Last Price Increase: 2024-04-29
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 19, 2024
Copy link

melvin-bot bot commented Apr 19, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

@MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@MitchExpensify
Copy link
Contributor

Reproduced, I don't see another report of this, labelling external

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@MitchExpensify MitchExpensify added External Added to denote the issue can be worked on by a contributor Overdue labels Apr 22, 2024
@melvin-bot melvin-bot bot changed the title iOS - Chat - Contacts in the mention suggestion list overlap [$250] iOS - Chat - Contacts in the mention suggestion list overlap Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01754fc1f82dc0f2e2

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 22, 2024
@MitchExpensify
Copy link
Contributor

Waiting on proposals, reassigning as I'm going OOO until the 7th; I'll take it back upon return! 🙇

@melvin-bot melvin-bot bot removed the Overdue label Apr 25, 2024
@MitchExpensify MitchExpensify removed their assignment Apr 25, 2024
@MitchExpensify MitchExpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MitchExpensify MitchExpensify self-assigned this Apr 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
Copy link

melvin-bot bot commented Apr 29, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Apr 29, 2024

@johncschuster, @Pujan92, @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@johncschuster
Copy link
Contributor

Thanks for the comment, @MitchExpensify! I'll watch for #40508 to close and then see if this behavior persists.

@MitchExpensify
Copy link
Contributor

Back from OOO so taking this back @johncschuster

@WoLewicki
Copy link
Contributor

@WoLewicki Do you think swapping with FlatList will be fine here?

Sorry for the late response. I think we can try and go with such option but is it not the case that there can be many many items in such list based on how many users can be listed there? I think it would be best to try and investigate the root of the problem, but since it can take much time, we could try to swap it with FlatList as long as it works correctly 🚀

@melvin-bot melvin-bot bot added the Overdue label May 14, 2024
@MitchExpensify
Copy link
Contributor

On hold, Melvin

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 14, 2024
Copy link

melvin-bot bot commented May 20, 2024

@Pujan92, @MitchExpensify Huh... This is 4 days overdue. Who can take care of this?

@MitchExpensify
Copy link
Contributor

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 20, 2024
Copy link

melvin-bot bot commented May 24, 2024

@Pujan92, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@MitchExpensify
Copy link
Contributor

On hold

@melvin-bot melvin-bot bot removed the Overdue label May 26, 2024
Copy link

melvin-bot bot commented May 29, 2024

@Pujan92, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label May 29, 2024
Copy link

melvin-bot bot commented May 30, 2024

@Pujan92, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@MitchExpensify
Copy link
Contributor

On hold for for #40508

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 2, 2024
@Pujan92
Copy link
Contributor

Pujan92 commented Jun 6, 2024

I am not able to reproduce this issue as other PR of using Flatlist seems solved this issue.
@lanitochka17 Could you plz confirm

@melvin-bot melvin-bot bot removed the Overdue label Jun 6, 2024
@saracouto saracouto added Monthly KSv2 and removed Daily KSv2 labels Jun 7, 2024
@Pujan92
Copy link
Contributor

Pujan92 commented Jun 14, 2024

Bump @lanitochka17 for the retest.

@lanitochka17
Copy link
Author

Issue is not reproducible

RPReplay_Final1718381452.MP4

@Pujan92
Copy link
Contributor

Pujan92 commented Jun 15, 2024

Thanks @lanitochka17 , @MitchExpensify We can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants