Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] iOS - LHN - Unable to open Concierge chat in LHN after creating new account #40604

Closed
1 of 6 tasks
lanitochka17 opened this issue Apr 19, 2024 · 31 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: .1.4.63-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Log in with a new GMAIL account
  3. Tap on Concierge chat

Expected Result:

Concierge chat opens

Actual Result:

Nothing happens when tapping on Concierge chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6455180_1713548334754.rpreplay_final1713548092.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016a973a840d55da5c
  • Upwork Job ID: 1781405725012254720
  • Last Price Increase: 2024-04-26
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 19, 2024
Copy link

melvin-bot bot commented Apr 19, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@joekaufmanexpensify
Copy link
Contributor

Interesting. I can reproduce, and only on a new gmail/public domain account.

2024-04-19_15-30-28.mp4

@joekaufmanexpensify joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Apr 19, 2024
Copy link

melvin-bot bot commented Apr 19, 2024

Job added to Upwork: https://www.upwork.com/jobs/~016a973a840d55da5c

@melvin-bot melvin-bot bot changed the title iOS - LHN - Unable to open Concierge chat in LHN after creating new account [$250] iOS - LHN - Unable to open Concierge chat in LHN after creating new account Apr 19, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 19, 2024
Copy link

melvin-bot bot commented Apr 19, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

@shahinyan11
Copy link

shahinyan11 commented Apr 20, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - LHN - Unable to open Concierge chat in LHN after creating new account

What is the root cause of that problem?

There it doesn't matter whether the user is new or not, the error is actual if there is only one element in the list.
It is a bug of the @shopify/flash-list package , currently we use 1.6.3. I tried to update to the latest version 1.6.4 and the Concierge chat started working, but a red layer with some message appeared on it.. At this moment package has problems with new architecture of react native. See below attachment.

Screenshot 2024-04-20 at 16 34 55.

What changes do you think we should make in order to solve the problem?

Add disableAutoLayout={true} prop for FlashList component. Here In the package documentation is mentioned that we need to set the disableAutoLayout to true while you apply special behavior to the CellRendererComponent

What alternative solutions did you explore? (Optional)

Add one empty View as a first item in list

@sword1202
Copy link

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0194d962e1f9098218
I would like to join to slack channel.

@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@joekaufmanexpensify
Copy link
Contributor

Proposals pending review

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@paultsimura
Copy link
Contributor

@joekaufmanexpensify please reassign a random C+ – I'm going OOO soon, trying to wrap up my current tasks this week.

@joekaufmanexpensify
Copy link
Contributor

Sounds good. Will do!

@joekaufmanexpensify joekaufmanexpensify added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

@joekaufmanexpensify
Copy link
Contributor

Pending review from @ahmedGaber93

@ahmedGaber93
Copy link
Contributor

@joekaufmanexpensify @shahinyan11
I can't reproduce in simulator (iOS 17.2) with the latest main, is anyone still able to reproduce?
Also, after create a new account, I can see two chats in chat list (slefDM and Concierge).

Screen.Recording.2024-04-23.at.6.14.25.PM.mov

@shahinyan11
Copy link

@joekaufmanexpensify @shahinyan11 I can't reproduce in simulator (iOS 17.2) with the latest main, is anyone still able to reproduce? Also, after create a new account, I can see two chats in chat list (slefDM and Concierge).

@ahmedGaber93 I mentioned in my proposal that it reproducible only if there is one chat in . So It can't be reproducible with multiple chats

@ahmedGaber93
Copy link
Contributor

@shahinyan11 Ah, after trying to force LHNOptionsList.tsx to display only one chat here, I can reproduce.

- data={data}
+ data={[data[0]]}

@ahmedGaber93
Copy link
Contributor

Another cases for this issue (Flashlist item not clickable).

  1. Login with new account (important to limit the result in step 3).
  2. Open selfDM chat.
  3. In composer type @, the mention suggestion displays 3 items (here, concierge, you).

Issue 1: if you click on the last item, the last item not clickable.
Issue 2: sometimes last item jumps to the previous item and last item space appear as empty space.
Issue 3: if you type @yourEmail and Flashlist displays only one item (you). The item is not clickable.

Screen.Recording.2024-04-23.at.8.27.45.PM.mov

@ahmedGaber93
Copy link
Contributor

@shahinyan11 Thanks for the proposal, your proposal works in this issue case, but not works for a similar cases here #40604 (comment), also I think it is workaround as the issue seem related to Flashlist with new arch.

After applied your fix.

Screen.Recording.2024-04-23.at.8.39.42.PM.mov

@ahmedGaber93
Copy link
Contributor

I think this issue is related to #13767, and have similar root cause of

Because I see @WoLewicki and @roryabraham work here #40191 (this PR is reverted) to fix Flashlist issues, I tagged you here to confirm you are aware of this issue.

Thanks!

@shahinyan11
Copy link

Another cases for this issue (Flashlist item not clickable).

  1. Login with new account (important to limit the result in step 3).
  2. Open selfDM chat.
  3. In composer type @, the mention suggestion displays 3 items (here, concierge, you).

Issue 1: if you click on the last item, the last item not clickable. Issue 2: sometimes last item jumps to the previous item and last item space appear as empty space. Issue 3: if you type @yourEmail and Flashlist displays only one item (you). The item is not clickable.

@ahmedGaber93 Are you tried to add disableAutoLayout={true} form mentions FlashList ?

@shahinyan11
Copy link

also I think it is workaround as the issue seem related to Flashlist with new arch.

@ahmedGaber93 Why a workaround. I mentioned an article in the official documentation where it is suggested to use disableAutoLayout={true}

@ahmedGaber93
Copy link
Contributor

Are you tried to add disableAutoLayout={true} form mentions FlashList ?

Yes, add here the result #40604 (comment)

@joekaufmanexpensify
Copy link
Contributor

@ahmedGaber93 are we close to selecting a proposal here?

@ahmedGaber93
Copy link
Contributor

@joekaufmanexpensify Unfortunately, the above proposal does not fix the issue.
We are still waiting for proposals.

@joekaufmanexpensify
Copy link
Contributor

Got it, sounds good!

Copy link

melvin-bot bot commented Apr 26, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
@joekaufmanexpensify
Copy link
Contributor

Awaiting proposals

@melvin-bot melvin-bot bot removed the Overdue label Apr 29, 2024
@joekaufmanexpensify
Copy link
Contributor

Still awaiting proposals

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@joekaufmanexpensify
Copy link
Contributor

Yep, this is working fine for me too now. Closing as whatever the issue was, it seems to have been fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants