Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2024-07-17] Clicks are interrupted on iOS #40613

Closed
1 of 6 tasks
roryabraham opened this issue Apr 19, 2024 · 22 comments
Closed
1 of 6 tasks

[$250] [HOLD for payment 2024-07-17] Clicks are interrupted on iOS #40613

roryabraham opened this issue Apr 19, 2024 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 19, 2024

HOLD on software-mansion/react-native-screens#2107


If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.63-11
Reproducible in staging?: yes
Reproducible in production?: not sure, but we think probably yes
Slack conversation: https://expensify.slack.com/archives/C06UTGZBWCA/p1713542919463249

Action Performed:

  1. Open the app
  2. Scroll down
  3. Tap on some report that was not in view before you scrolled down. When you do this, slide your finger to the left of right, making sure to keep it over the report.

Expected Result:

The report should be opened

Actual Result:

Nothing happens

Workaround:

Don't slide your finger at all when tapping on the report.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011d2b3beed0f9d8ce
  • Upwork Job ID: 1814432666103182597
  • Last Price Increase: 2024-07-19
Issue OwnerCurrent Issue Owner: @shubham1206agra
@roryabraham roryabraham added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 19, 2024
Copy link

melvin-bot bot commented Apr 19, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@roryabraham
Copy link
Contributor Author

note that this is very similar to #40048, but on iOS instead of Android. We think that this will be fixed by #40560, which is iOS-specific. For that reason, we think that this is a different bug with a similar symptom

@roryabraham
Copy link
Contributor Author

roryabraham commented Apr 19, 2024

verified that this was fixed by #40560. No payments are due. I'm keeping this open for the sake of tracking the upstream PR and making sure that we upgrade react-native-screens and remove this patch when it's released upstream.

Putting this on HOLD for software-mansion/react-native-screens#2107 and making this a weekly in the meantime

@roryabraham roryabraham added Weekly KSv2 and removed Daily KSv2 labels Apr 19, 2024
@roryabraham roryabraham self-assigned this Apr 19, 2024
@roryabraham roryabraham changed the title Clicks are interrupted on iOS [HOLD] Clicks are interrupted on iOS Apr 19, 2024
@roryabraham
Copy link
Contributor Author

software-mansion/react-native-screens#2107 was merged but not released yet. Awaiting another release of react-native-screens

@kevinksullivan
Copy link
Contributor

Going to remove myself + bug so this isn't tracked for a project. Lmk if I am misunderstanding @roryabraham

@kevinksullivan kevinksullivan removed the Bug Something is broken. Auto assigns a BugZero manager. label Apr 29, 2024
@kevinksullivan kevinksullivan removed their assignment Apr 29, 2024
@roryabraham
Copy link
Contributor Author

roryabraham commented May 3, 2024

Still on HOLD pending another release of react-native-screens, current version in 3.31.1

@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@roryabraham
Copy link
Contributor Author

Still awaiting another release

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2024
@melvin-bot melvin-bot bot added the Overdue label May 23, 2024
@roryabraham
Copy link
Contributor Author

Still awaiting another release after 3.31.1

@melvin-bot melvin-bot bot removed the Overdue label May 23, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 3, 2024
@roryabraham
Copy link
Contributor Author

same ^

@melvin-bot melvin-bot bot removed the Overdue label Jun 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 19, 2024
@roryabraham roryabraham changed the title [HOLD] Clicks are interrupted on iOS Clicks are interrupted on iOS Jun 26, 2024
@roryabraham
Copy link
Contributor Author

roryabraham commented Jun 26, 2024

This is ready to come off HOLD, react-native-screens 3.32 has been released: https://github.com/software-mansion/react-native-screens/releases/tag/3.32.0

@melvin-bot melvin-bot bot removed the Overdue label Jun 26, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] Clicks are interrupted on iOS [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Clicks are interrupted on iOS Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 16, 2024
@roryabraham
Copy link
Contributor Author

kk, $250 due to @ahmedGaber93 for the review of #44427

@melvin-bot melvin-bot bot removed the Overdue label Jul 19, 2024
@roryabraham roryabraham changed the title [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Clicks are interrupted on iOS [HOLD for payment 2024-07-17] Clicks are interrupted on iOS Jul 19, 2024
@roryabraham roryabraham added Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor labels Jul 19, 2024
Copy link

melvin-bot bot commented Jul 19, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] Clicks are interrupted on iOS [$250] [HOLD for payment 2024-07-17] Clicks are interrupted on iOS Jul 19, 2024
Copy link

melvin-bot bot commented Jul 19, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011d2b3beed0f9d8ce

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 19, 2024

This comment was marked as outdated.

@roryabraham roryabraham removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Jul 19, 2024
@roryabraham
Copy link
Contributor Author

@lschurr this is ready to pay out whenever you come through this issue. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jul 22, 2024
@lschurr
Copy link
Contributor

lschurr commented Jul 22, 2024

Offer sent to @ahmedGaber93

@melvin-bot melvin-bot bot removed the Overdue label Jul 22, 2024
@ahmedGaber93
Copy link
Contributor

@lschurr offer accepted

@lschurr
Copy link
Contributor

lschurr commented Jul 22, 2024

Payment summary:

@lschurr lschurr closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants