Submit Expense - Header Remains as "Submit Expense" Instead of "Manual"

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.64.0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #35822
Issue reported by: Applause - Internal Team

Action Performed:

1, Tap on the FAB > "Submit Expense."
2, Choose the "Manual" option and input the amount.
3, Click "Next." Observe that the header continues to display "Submit Expense" instead of changing to "Manual."

Expected Result:

The header should change to "Manual" after entering the amount and clicking "Next."

Actual Result:

The header remains as "Submit Expense" instead of changing to "Manual" during the expense submission process.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6457689_1713805134082.Screen_Recording_2024-04-22_at_9.57.55_AM.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-split

[suneox]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submit Expense - Header Remains as "Submit Expense" Instead of "Manual"

What is the root cause of that problem?

Regression from new feature implementation

What changes do you think we should make in order to solve the problem?

At this line we should get translation by requestType based on 3 cases Distance, Manual, Scan

Base on the requestType we can get translation from

    tabSelector: {
        ...
        distance: 'Distance',
        manual: 'Manual',
        scan: 'Scan',
    },

Keep the same with previous release
or

    quickAction: {
        ...
        trackManual: 'Track expense',
        trackScan: 'Track receipt',
        trackDistance: 'Track distance',
    },

To make consistent with quickAction

What alternative solutions did you explore? (Optional)

[francoisl]

Looks like this is expected based on this thread.

There's going to be a follow-up issue to update the headers for all money request flows later (it will also not go back to saying "Manual")

[mountiny]

Correct this is no expected behaviour, thanks ❤️