Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Distance - Gap displayed between start&finish after moving stops and deleting one #40753

Closed
1 of 6 tasks
izarutskaya opened this issue Apr 23, 2024 · 26 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Apr 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.64-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4504672
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: user is a member of a workspace

  1. Open the app and log in
  2. Tap FAB > Submit expense > Distance
  3. Enter 3 waypoints
  4. Drag and drop the middle stop to make it the finish location
  5. Delete one of the waypoints

Expected Result:

There is no gap between the start and finish waypoints

Actual Result:

Gap is displayed between the start and finish points

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6458253_1713840321942.video_2024-04-22_22-41-06.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010136e7715586d143
  • Upwork Job ID: 1782700920406261760
  • Last Price Increase: 2024-05-07
Issue OwnerCurrent Issue Owner: @garrettmknight
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 23, 2024
Copy link

melvin-bot bot commented Apr 23, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 23, 2024

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 23, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@garrettmknight I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@izarutskaya
Copy link
Author

Production

Screen_Recording_20240423_120431_New.Expensify.mp4

@garrettmknight garrettmknight removed the DeployBlockerCash This issue or pull request should block deployment label Apr 23, 2024
@garrettmknight
Copy link
Contributor

I don't think we need to block the deploy for this, but I've reproduced. Opening it up.

@garrettmknight garrettmknight added External Added to denote the issue can be worked on by a contributor Daily KSv2 labels Apr 23, 2024
@melvin-bot melvin-bot bot changed the title Distance - Gap displayed between start&finish after moving stops and deleting one [$250] Distance - Gap displayed between start&finish after moving stops and deleting one Apr 23, 2024
@garrettmknight garrettmknight removed the Hourly KSv2 label Apr 23, 2024
Copy link

melvin-bot bot commented Apr 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~010136e7715586d143

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 23, 2024
Copy link

melvin-bot bot commented Apr 23, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@garrettmknight
Copy link
Contributor

Still waiting on proposals

@garrettmknight
Copy link
Contributor

Still waiting on proposals

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 3, 2024
Copy link

melvin-bot bot commented May 7, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented May 7, 2024

@garrettmknight @danieldoglas @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented May 7, 2024

@garrettmknight, @danieldoglas, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented May 7, 2024

@garrettmknight @danieldoglas @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@Krishna2323
Copy link
Contributor

This will be fixed by this PR. We can hold.

Copy link

melvin-bot bot commented May 8, 2024

@garrettmknight, @danieldoglas, @thesahindia Huh... This is 4 days overdue. Who can take care of this?

@garrettmknight
Copy link
Contributor

garrettmknight commented May 9, 2024

Thanks @Krishna2323 - will hold on #40105

@melvin-bot melvin-bot bot removed the Overdue label May 9, 2024
@garrettmknight garrettmknight changed the title [$250] Distance - Gap displayed between start&finish after moving stops and deleting one [HOLD on #40105] [$250] Distance - Gap displayed between start&finish after moving stops and deleting one May 9, 2024
@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@garrettmknight
Copy link
Contributor

Still holding

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2024
@garrettmknight garrettmknight added Weekly KSv2 and removed Daily KSv2 labels May 13, 2024
@melvin-bot melvin-bot bot added the Overdue label May 21, 2024
@garrettmknight
Copy link
Contributor

Still holding on #40105

@melvin-bot melvin-bot bot removed the Overdue label May 22, 2024
@garrettmknight
Copy link
Contributor

Still holding on #40105

@melvin-bot melvin-bot bot added the Overdue label Jun 7, 2024
@garrettmknight garrettmknight added Daily KSv2 and removed Weekly KSv2 labels Jun 10, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 10, 2024
@garrettmknight garrettmknight changed the title [HOLD on #40105] [$250] Distance - Gap displayed between start&finish after moving stops and deleting one [$250] Distance - Gap displayed between start&finish after moving stops and deleting one Jun 10, 2024
@garrettmknight
Copy link
Contributor

We're off hold - updating to daily to test tomorrow.

@garrettmknight
Copy link
Contributor

Confirmed this is fixed. Closing.

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants