Deploy Checklist: New Expensify 2024-04-23

[github-actions]

Release Version: 1.4.65-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Implement suggestion for edit composer #35226
• [No QA] Move skip condition if from step to job in Expensify Help deploy workflow #38948
• remove subscript workspace avatar from expense report #39473
• [Onboarding - Stage 2] Onboarding Flow - enabled #39687
• fix: app shows full page notfound in ws features page #39835
• fix: Standardize the hover menu options to always include the same options #39894
• feature: implement qbo advanced configuration screens #39899
• [NoQA] Adding "avoid anonymous function" eslint rule into the app #39942
• Fix: style of page Transfer balance #39944
• Edit track expense #39956
• Default badge style #40101
• [NoQA] Reassure: refactor tests for more complex components #40163
• [Mentions v2] Update auto-complete widget to perform online search when needed #40232
• fix: Track expense shortcut doesn't update to the correct one in offline mode #40267
• Fix numpad longpress back key #40288
• [NO QA] Fullstory integration #40294
• Remove underscore usage #40346
• Assign false to the POLICY_HAS_CONNECTIONS_DATA_BEEN_FETCHED Onyx key when the fetching of connections data fails #40375
• Reusable and stylable money request amount input #40390
• Display an explanatory text on categories screen #40496
• Add logs to debug production chat loading issue #40501
• enable tooltip for group title #40528
• Fix: "Let it go" copy is not centered when dragging and dropping a file to Scan RHP #40545
• [QAB] Skip confirmation for track flows #40574
• Update README.md with more Xcode instructions #40575
• Fix missing translation shown in notification preference #40623
• Create Create-a-report-approval-workflow.md #40630
• Create Assign-or-remove-a-Copilot.md #40634
• Create Assign-report-approvers-to-specific-employees.md #40635
• Create Track-report-history.md #40636
• Create Require-review-for-over-limit-expenses.md #40638
• Create Set-a-random-report-audit-schedule.md #40639
• Cache measured sizes in ThumbnailImage #40643
• Change the intent for Looking Around Onboarding Flow #40667
• [Fix] Map reloads with "Route pending" #40674
• [Search v1] Add empty search List skeleton #40682
• [NoQA] Fix dashboard send data #40687
• Swap from withPolicy to withPolicyConnections for Export Quickbooks pages #40713
• [NoQA] Update the adhoc provisioning profile with Daniel and Tom iphones #40714
• Format ISO string correctly when missing reportAction to find mostRecentReportActionLastModified #40734
• [No QA] Remove doesDomainHaveApprovedAccountant from Account type #40738
• Fix confirmation page isn't closed after completing share expense #40740
• Fix no result found doesn't show when the search found nothing in categorize expense #40748
• Fix bug with Removed member can be clicked #40758
• [CP Staging] Changing properties being used by Fullstory #40807
• [NO QA] Changing from gtm to thirdPartyScripts.js and including Fullstory #40817
• [CP Staging] Fix: Android - Workspace list - Workspace name and email address are truncated #40824
• [CP Staging] Revert "Implement suggestion for edit composer" #40865
• [CP Staging] Don't show the loading screen when the connections feature is not enabled #40893
• [CP Staging] Revert Fullstory lib changes #40894
• [CP Staging] Don't include X-Chat-Attachment-Token header for static video thumbnails #40924

Internal QA:

• [NO QA] Fullstory integration #40484 - @luacmartins

Deploy Blockers:

• [HOLD for payment 2024-06-06] [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] [$250] Android - Chat - Mention suggestion gets behind other UI components while in edit mode #40854
• [HOLD for payment 2024-06-06] [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] Chat - Unable to dismiss comment edit with ESC key #40856
• [HOLD for payment 2024-06-06] [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] Web - "Error: FullStory is not loaded" console error shows up #40860
• Chat - User mention is not highlighted as mention when mentioning someone in edited comment #40861
• [$250] Track expense - App shows skeleton when saving track expense edit for the second time onward #40862
• Track Expense - Amount is not shown when going through QAB track flow #40863
• [HOLD for payment 2024-06-06] Chat - Suggestion list does not appear below composer when it is near chat header #40864
• iOS - Chat - Suggestion list in edit composer is easily dismissed when scrolling down the list #40866
• Track expense - In track expense, edit amount shows dollar briefly #40873
• [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] [$250] iOS - App crashes when trying to upload a video #40874
• [HOLD for payment 2024-05-03] Unable to load categories in the workspace settings #40875
• [HOLD for payment 2024-06-13] [$250] [Guided Setup] Redirect where user was when they try to deeplink to the onboarding flow after completion #40876
• HIGH: [Live Markdown] [$500] Android - Chat - User unable to select complete sentence #40890
• [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] [$250] Chat - Black Video Preview Issue in Concierge Welcome Message #40907
• [HOLD for payment 2024-06-06] [HOLD for payment 2024-06-05] [HOLD for payment 2024-05-03] [HOLD for payment 2024-05-02] iOS - Onboarding - App crashes during "Track business spend for taxes" onboarding flow #40910
• [Payment due 2024-05-14][$250] iOS - Track expense - Swiping to right on invite page does not return to workspace chat #40913
• Onboarding - Onboarding modal doesn't get shown for expensifail accounts #40915
• [$250] Web - Unable to open public room when user is signed out #40917
• [$250] Attachment - The app crashes when attempting to open larger specific pdf #40925

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[Julesssss]

#40854 not critical enough to block deploy, checked off

[mountiny]

checking #35226 off as the pr was reverted

[mountiny]

Checked off the full story related PRs as we have reverted them

[kbecciv]

TR is 35% left

#39687 is failing with #40915
#39944 -asked if it can be verified internally #39944 (comment)
#39956 is failing on Web #40854
#40574 - pending verification on Desktop
#40713 - pending verification on Desktop

Deploy Blockers:
#40890
#40907
#40917
#40925

[mountiny]

checking #39687 off as we wont show this for domain controlled accounts

[mountiny]

demoted #40925

[kbecciv]

TR is 3% left

#40574 is failing with #40863
#40713 is failing with #40914 on Web and mWeb, blocked in IOS app with #40517

Deploy Blockers:
#40890

[kbecciv]

TR is completed!
#40574 is failing with #40863
#40713 is failing with #40914 on Web and mWeb, blocked in IOS app with #40517

Deploy Blockers:
#40890

[mountiny]

demoted #40890

[mountiny]