[HOLD for payment 2024-07-24] [$500] mWeb-Scan-On refreshing scan submit expense confirmation page all details are disappeared

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.65
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4510603
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap fab -- submit expense - scan
3. Upload an image using camera
4. Select a user
5. Enter description and save it
6. Refresh the page

Expected Result:

On refreshing scan submit expense confirmation page all details must not be disappeared

Actual Result:

On refreshing scan submit expense confirmation page all details are disappeared. To and description details also disappeared

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460480_1713976463563.fhj13.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a06fc87f92014ba9
• Upwork Job ID: 1783312719597031424
• Last Price Increase: 2024-06-07
• Automatic offers:
• s77rt | Reviewer | 102676237
• dominictb | Contributor | 102676238

Issue Owner

Current Issue Owner: @bfitzexpensify / @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a06fc87f92014ba9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb-Scan-On refreshing scan submit expense confirmation page all details are disappeared

Looking at this comment I think the current Expected Result: is incorrect

What is the root cause of that problem?

After the refresh, the screen is navigated twice. The first one is when the NavigationRoot component is rendered and second from here. So when the screen opens first time the code navigates back to start screen as a result of this call and then the second navigation occurs and the scan confirmation screen opens again

What changes do you think we should make in order to solve the problem?

Wrap this line in InteractionManager.runAfterInteractions

What alternative solutions did you explore? (Optional)

In shouldSkipDeepLinkNavigation function add check if the route equal to ROUTE.MONEY_REQUEST_STEP_CONFIRMATION and return true

[abdulrahuman5196]

Checking now

[abdulrahuman5196]

@shahinyan11 The root cause on the proposal makes sense. I can visually see we are routing to starting step and routing again to confirmation page.

But I am not aligned on the solution suggested and have further questions.

Wrap this line in InteractionManager.runAfterInteractions

I tried this on mac web and didn't work for me.

In shouldSkipDeepLinkNavigation function add check if the route equal to ROUTE.MONEY_REQUEST_STEP_CONFIRMATION and return true

I don't think we should do this since its a centralized deeplinking code and adding screen specific logic should be avoid.

And another question is On root cause being true, this means does every screen on refresh being navigate twice? But I don't see that happening. If so we should fix the navigation happening multiple times.

[shahinyan11]

And another question is On root cause being true, this means does every screen on refresh being navigate twice? But I don't see that happening. If so we should fix the navigation happening multiple times.

In both places, there are a few if blocks with early return before navigating. So this behavior is not for every screen and there may be screens for which it happens early return.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@bfitzexpensify, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[bfitzexpensify]

Update on this one @abdulrahuman5196?

[abdulrahuman5196]

I tried this on mac web and didn't work for me.

@shahinyan11 where you able to check on this?

[abdulrahuman5196]

Update on this one @abdulrahuman5196?

We don't have proposals to approve yet

[shahinyan11]

I tried this on mac web and didn't work for me.

@shahinyan11 where you able to check on this?

@abdulrahuman5196 It works for me on mac web with InteractionManager.runAfterInteractions

Untitled.mov

[melvin-bot]

@bfitzexpensify @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

@dominictb Thanks for looking into the bug. The updated solution looks good to me 👍.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bfitzexpensify]

Hey @dominictb - how is this one going?

[dominictb]

@bfitzexpensify PR still under review!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: do not refresh draft txn after redirect #44363

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment automatic offer (Reviewer)
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Refactor participant selector page #40370
• The offending PR has been commented on: Refactor participant selector page #40370 (comment)
• A discussion in #expensify-bugs has been started: Not needed (unique bug)
• Determine if we should create a regression test for this bug: No (this seems already coming from a TestRail test)

[bfitzexpensify]

Payments complete, closing this out.