Deploy Checklist: New Expensify 2024-04-25

[github-actions]

Release Version: 1.4.66-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Use fallback user avatar in cases where the user is unknown to us #39229
• [NO QA] Fullstory integration #40294
• [Search v1] Add SearchFilters component #40419
• Fixes ability to mention reports for room invited users #40506
• Replace policy.submitsTo with PolicyUtils.getSubmitToAccountID #40532
• Not here error appears briefly when enabling features #40650
• fix allow to search selfDM in new chat page #40672
• Fix unread issue in combine report #40676
• Onboarding fixes #40688
• [Fix]: Fix crash on Expense Report Title due to mismatch of reportKey on the FE and BE #40704
• Swap from withPolicy to withPolicyConnections for Import Quickbooks pages #40716
• Swap from withPolicy to withPolicyConnections for advanced Quickbooks pages  #40718
• fix: Quick action - 'Pay elsewhere' button is small when paying someone via Quick action #40727
• Rename search page #40728
• fix workspace list does not show #40730
• [CP Staging] Changing properties being used by Fullstory #40807
• [NO QA] Changing from gtm to thirdPartyScripts.js and including Fullstory #40817
• [NO QA] Fix withPolicyConnections #40839
• Fix new room description field error message is overlapped by other fields highlight #40851
• docs: fix typos, punctuation, formatting #40859
• Perform mention report search only in policy rooms #40867
• Onboarding videos #40871
• [No QA]: Complete the final cleanup for distance request refactoring #40896
• Update Export Pages for Company Cards to include amendments #40902
• fix: copy state in reanimated commit hook #40905
• Fix text highlighting and cursor position in Live Markdown input on web #40923
• [Guided Setup] Use proper thumbnails for guided setup videos #40933
• Fix create new group chat when creating split bill via QAB #40961
• Fix the command name #41002
• [CP Stg] Re-enable android production deploys #41039
• [CP Staging] Disallow blank first names, allow blank surnames during onboarding #41047
• [CP Staging] Revert "Use fallback user avatar in cases where the user is unknown to us" #41087
• [CP Staging] Revert "Fix unread issue in combine report" #41099

Deploy Blockers:

• [HOLD for payment 2024-06-06] [No payment] Workspace - Not here page shows up when opening profile of invited user in offline mode #40989
• [HOLD #41846][$250] Task - Fallback avatar does not update after creating task unless chat header is opened #40991
• [$250] Workspace – Hmm it’s not here appears briefly in LHN when delete WS #40993
• [HOLD for payment 2024-06-06] [HOLD for payment 2024-05-06] [HOLD for payment 2024-05-03] Quick action - Fallback avatar is displayed on quick action after user avatar loads #40996
• Onboarding - Onboarding video does not have an audio #41000
• IOU - Not found view is briefly shown when refreshing page while expense title RHP is open #41005
• [$250] Android - Chat - Emoji keyboard can not be activated when no other character is added in chat box #41011
• [Payment Request] [$250] Mention - Avatar is not displaying on Concierge in mention list #41014
• [HOLD for payment 2024-07-22][$125] mWeb - IOU - Clicking back from expense title edit page after a refresh takes to LHN #41017
• Sign up - An error appears in Concierge chat when pass onboarding modal with spaces #41024
• Android - Chat - New message text is hidden under the green line when mark as unread #41025
• [Wave Collect] IOU - Application crashes when trying to select IOU category #41029
• Android & iOS - App crashes when switching between Settings and Chat after deleting expense #41031
• VBA Onfido - No message with the instructions in Concierge chat #41065
• [$250] Expense - Combined report in LHN is always bolded after modifying transaction #41088
• [QBO] Error message appears when change any of the configuration on Advanced tab #41092
• [Awaiting Payment May 15th] [QBO] advanced configuration: selected accounts are not selected after Relogin #41095

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[rlinoz]

Demoted #40991

[roryabraham]

Demoted #41017

[francoisl]

Demoted #41031 as can't repro

[mountiny]

demoted #41000

[kavimuru]

Regression is 2% left in the TR
#40718 failing with #40914 and #40978
#40676 failing with #40911 reproduced in production checking it off
#40532 Validation pending in mweb
#41047 - validation pending

[mountiny]

demoted #41065

[mountiny]

Demoted #40993 - minor UX issue

[mountiny]

demoted #41011 - its very specific issue for limited number of devices too

[mountiny]

checking #41014, #40989 and #40996 off as they have been fixed by a revert

[kavimuru]

Regression is completed

[thienlnam]

There's a fresh crash

CameraDeviceDetails.getFormats

Fatal Exception: java.lang.IllegalArgumentException
lower must be less than or equal to upper
android.util.Range.<init> (Range.java:59)
com.mrousavy.camera.core.CameraDeviceDetails.getFormats (CameraDeviceDetails.java:125)
com.mrousavy.camera.core.CameraDeviceDetails.toMap (CameraDeviceDetails.java:79)
com.mrousavy.camera.CameraDevicesManager.getDevicesJson (CameraDevicesManager.kt:87)
com.mrousavy.camera.CameraDevicesManager.sendAvailableDevicesChangedEvent (CameraDevicesManager.kt:94)
com.mrousavy.camera.CameraDevicesManager$initialize$1.invokeSuspend (CameraDevicesManager.kt:71)
kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:33)

Looks related to vision camera - going to bring up in expensify-margelo 1.4.61-8 (1001046108)

[mountiny]

Graphs looking alright and new crash has been reported by Jack above and shared with Margelo

[mountiny]