[Hold for payment 2024-06-03] [$250] [Wave Collect][QBO] Prevent the simultaneous enabling of JE export and Tax import

[hayata-suenaga]

Prevent the user from enabling Tax import and selecting Journal Entry (JE) as the export destination of out-of-pocket expenses at the same time.

When the Tax import is enabled, the Journal Entry should not appear as an option of QBO entities to export out-of-pocket expenses to. Also a text explaining the reason why Journal Entry option is hidden should be displayed.

When Journal Entry is selected as the entity to be used, the switch to enable Tax import should be disabled. Also, a text explaining why Tax import is disabled should be displayed.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011e0178d63e9af45a
• Upwork Job ID: 1783687091422687232
• Last Price Increase: 2024-04-26
• Automatic offers:
• rojiphil | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011e0178d63e9af45a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[gijoe0295]

@hayata-suenaga Hmm I think it's currently working like that:

App/src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocketExpenseConfigurationPage.tsx

Line 25 in ae980e8

const shouldShowTaxError = isTaxesEnabled && exportEntity === CONST.QUICKBOOKS_EXPORT_ENTITY.JOURNAL_ENTRY;

I enabled taxes in Import >> Taxes

And the error apparently shows in Export out-of-pocket expenses page:

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Warn the user of the error that happens when Journal Entry is selected as the out-of-pocket expense export destination while tax is enabled.

This part of the OP is already covered in here

However, there's a related bug.

1. The user already selects Journal entry
2. Then enable the Tax
3. Then go back to the Export as screen, do not select anything
4. Then go back to accounting/quickbooks-online/export screen, they will see a RBR on Export as without any reason.

What is the root cause of that problem?

In step 3, we'll check that tax is already enabled, so we see a TaxError and will attempt to clear the config here

However, we don't pass anything as settingValue, so it will be undefined, when no settingValue is sent to the back-end here, it will throw an error.

What changes do you think we should make in order to solve the problem?

We need to default it to null/empty string by ?? here.

Alternatively, we can pass null as settingValue here and update here such that if the settingValue is nully, it will be used as is without JSON.stringify.

I believe the back-end already supports sending null to clear the config, but in case it doesn't support yet, we should add support in back-end.

What alternative solutions did you explore? (Optional)

NA

[trjExpensify]

@teneeto is going to take this as QBO clean-up. @tienifr you can progress #41045.

[teneeto]

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take care of this issue.

[melvin-bot]

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[trjExpensify]

I don't think the OP as written is incredibly clear on what needs to be done for this issue. I think it would be good to outline what's expected, and then show a series of the mocks for each step to make that clear. There's an error message in-line when the JE/Tax misconfig happens in production already, what's missing?

Is it that there should be an RBR from the bottom tab > Accounting LHN > Export > etc etc all the way to where the error message is in-line? More broadly for errors in the accounting settings, is that pattern applied or does it need to be added for any in-line errors in the QBO accounting configuration?

@zanyrenney I'm going to assign this one to you for the time being to help clarify and firm up on what's needed here, as I couldn't make that out completely from this part of the doc.

[zanyrenney]

👋🏼 hey there! Thanks for assigning me Tom.

Breaking down the desired behaviour in steps.

1. User sets their export option as Journal Entries. They do not have Tax enabled so all export options are available.
2. User then enables Tax on the workspace
3. Then, we need to show the RBR for on the export option selected which is Journal Entries (as per step 1)
4. The RBR needs to show the error text “Journal entry is not available when taxes are enabled. Please select a different export option.”
5. On the Export as page, we should show Vendor bills and check as the only two options. NOT Journal entries
6. There is no "default" so both will appear unselected but in the selection list, available for either to be selected.
7. Once the user has selected either VBs or check, the RBR and error text should be removed.

[zanyrenney]

Is it that there should be an RBR from the bottom tab > Accounting LHN > Export > etc etc all the way to where the error message is in-line?

We should mirror the pattern from the error handling doc - here so show the RBR on workspace > accounting export

More broadly for errors in the accounting settings, is that pattern applied or does it need to be added for any in-line errors in the QBO accounting configuration?

Not sure what you mean here, we're showing the RBR on the QBO line in the accounting page > connections card. LMK what you mean specifically though!

[trjExpensify]

Breaking down the desired behaviour in steps.

1. User sets their export option as Journal Entries. They do not have Tax enabled so all export options are available.
2. User then enables Tax on the workspace
3. Then, we need to show the RBR for on the export option selected which is Journal Entries (as per step 1)
4. The RBR needs to show the error text “Journal entry is not available when taxes are enabled. Please select a different export option.”
5. On the Export as page, we should show Vendor bills and check as the only two options. NOT Journal entries
6. There is no "default" so both will appear unselected but in the selection list, available for either to be selected.
7. Once the user has selected either VBs or check, the RBR and error text should be removed.

You might have to walk me through this live. These steps don't make sense to me, I think they're actually impossible? As soon as you connect to QBO, you can't "enable tax on the workspace", the only way you can turn that feature on thereafter is by importing Taxes via the QBO integration. So in this scenario you've outlined, wouldn't this be:

1. Export as: Journal Entry
2. Taxes: not imported
3. We don't let them toggle on the Taxes import in the QBO settings because the Journal Entry export method is selected
4. Show hint text beneath the Taxes import page that explains why and that they need to pick either VBs or Check as an export method to import taxes

OR

1. Export as: Vendor bill (which will be the default set on initial connection as well)
2. Taxes: Imported
3. We don't let them choose "Journal Entry" in the "Export as" select list because taxes are imported via the integration
4. We show hint text beneath the Export as push row explaining why JEs aren't available and that they need to stop importing taxes to export as JEs.

More broadly for errors in the accounting settings, is that pattern applied or does it need to be added for any in-line errors in the QBO accounting configuration?

On this one, what I mean by it is that right now there isn't a "brick road" that leads to the specific field in error within the QBO integration pages. You have to go there to find it by yourself, so we should make sure that a solution is implemented for that. I.e

• RBR starts on the "Settings" bottom tab
• Red dot on the Workspaces menu item
• Red dot on the Workspace row that contains an error
• Red dot on the Accounting menu item within that Workspace
• Red dot on the applicable Export || Import || Advanced menu item where the error is
• Red dot and error message on the applicable field in error

[zanyrenney]

Happy to chat live if that helps Tom! This design was from this conversation: here

Jason raised it in the design doc and this was the solution proposed

But -- maybe this is an oversight and thinking through the bug found last week to do with Taxes (and the toggling!) it's this journey we're actually trying to solve for:

• Export as: Journal Entry
• Taxes: not imported
• We don't let them toggle on the Taxes import in the QBO settings because the Journal Entry export method is selected
• Show hint text beneath the Taxes import page that explains why and that they need to pick either VBs or Check as an export method to import taxes

[trjExpensify]

Okay, cool.. so I think these are the two cases that don't allow for the misconfiguration and then there's no in-line error message or anything like that.

Vendor bill (or Check) + taxes imported, can't export as Journal Entry

1. Export as: Vendor bill (which will be the default set on initial connection as well)
2. Taxes: Imported
3. We don't let them choose "Journal Entry" in the "Export as" select list because taxes are imported via the integration
4. We show hint text beneath the Export as push row explaining why JEs aren't available and that they need to stop importing taxes to export as JEs.

Journal Entry + Taxes not imported, can't import taxes

1. Export as: Journal Entry
2. Taxes: not imported
3. We don't let them toggle on the Taxes import in the QBO settings because the Journal Entry export method is selected
4. Show hint text beneath the Taxes import page that explains why and that they need to pick either VBs or Check as an export method to import taxes

CC: @JmillsExpensify

[trjExpensify]

PR is in review.

[trjExpensify]

@hayata-suenaga should we close this in favour of #41621?

Edit: Ignore that, we need to settle up here when the OG PR hits prod.

[hayata-suenaga]

Just as a clarification:

My PR is about location configuration

This issue is for the PR that handles tax configuration (which was done by Eto) 😄

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bfitzexpensify]

Adding another BZ team member to handle anything required on this while I'm OOO from today until June 11th:

@sonialiap - the PR - #41638 - is in review, and we'll just need to follow the usual BZ process once it's deployed.

[hayata-suenaga]

yes we just need a payment for @rojiphil as a C+ after the regression period is over

[rojiphil]

yes we just need a payment for @s77rt as a C+ after the regression period is over

@hayata-suenaga Some confusion here. I was the C+ reviewer here. Also reference here.
cc @trjExpensify @sonialiap

[hayata-suenaga]

ah sorry my bad I tagged a wrong C+ 🙇

[sonialiap]

PR deployed to production on May 27. +7 days puts payment on Jun 3

Payment summary:

• @rojiphil $250 - paid ✔️
• @s77rt $250 - offer sent - offer rejected

[s77rt]

@sonialiap I'm not due payment here. We can close the issue