[PAID] [$250] HIGH: [Polish] Revert the Message Concierge for help with setup message

[quinthar]

Problem:

We are working on "Stage 1/2 onboarding", which embeds training into the app for new users. One part of the design is to assign "tasks" to the user for onboarding steps. At one point we had talked about creating a new "Expensify" user to assign these tasks to you, and we will still do that in the future to A/B test the effectiveness of a new Expensify user, versus using Concierge. And when we do that we will make those tasks "read only" -- and encourage you to talk to Concierge about onboarding. This is the PR that added it. However, now Concierge is assigning them to you -- so this message is very confusing. Even worse, it's showing on the wrong chat (ie, in a public room):

Solution:

Let's just revert this message entirely and we can add it later when we are ready to show it. /cc @dubielzyk-expensify @anmurali

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fe3f4f4e21a87651
• Upwork Job ID: 1784733661373624320
• Last Price Increase: 2024-04-28
• Automatic offers:
• ishpaul777 | Reviewer | 0
• neonbhai | Contributor | 0
• shubham1206agra | Contributor | 0

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fe3f4f4e21a87651

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Revert the Message Concierge for help with setup message

What is the root cause of that problem?

We display the footer message here:

App/src/pages/home/report/ReportFooter.tsx

Line 144 in d47413d

{!canWriteInReport && <SystemChatReportFooterMessage />}

What changes do you think we should make in order to solve the problem?

We would check if the user is logged in and if he is missing the write permissions when rendering the Footer:

{!isAnonymousUser && !canWriteInReport && <SystemChatReportFooterMessage />}

What alternative solutions did you explore?

• Not sure if we would actually want to show this banner for system chats (concierge) since user always has write permissions for concierge chats

  • If this is not true, we would add a isConcierge check

    const isConcierge = ReportUtils.isConciergeChatReport(report)

• If we want to remove the banner we could comment this line for now

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Revert the Message Concierge for help with setup message

What is the root cause of that problem?

This message was added in this PR #40010

What changes do you think we should make in order to solve the problem?

Remove || !canWriteInReport from this line

App/src/pages/home/report/ReportFooter.tsx

Line 136 in d47413d

<View style={[styles.chatFooter, isArchivedRoom || isAnonymousUser || !canWriteInReport ? styles.mt4 : {}, isSmallScreenWidth ? styles.mb5 : null]}>

Remove this line

App/src/pages/home/report/ReportFooter.tsx

Line 144 in d47413d

{!canWriteInReport && <SystemChatReportFooterMessage />}

Remove these lines too

App/src/pages/home/report/ReportFooter.tsx

Line 85 in d47413d

const canWriteInReport = ReportUtils.canWriteInReport(report);

App/src/pages/home/report/ReportFooter.tsx

Line 24 in d47413d

import SystemChatReportFooterMessage from './SystemChatReportFooterMessage';

What alternative solutions did you explore? (Optional)

We can add another check here !isAnonymousUser

App/src/pages/home/report/ReportFooter.tsx

Line 144 in d47413d

{!canWriteInReport && <SystemChatReportFooterMessage />}

[ishpaul777]

This is straightforward revert so i am inclined to chose the first proposal i.e. from @neonbhai

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Current assignee @blimpich is eligible for the DeployBlockerCash assigner, not assigning anyone new.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

@ishpaul777 @neonbhai @Nodebrute rather than reverting, could you please propose a change that would keep the banner for "system" type chats but not for the public chats

Ideally i think we can just update the logic to show this concierge banner only when the Sign up public chat does not show (and the write permissions are missing)

[neonbhai]

Proposal updated

@mountiny @ishpaul777

[mountiny]

Can you also check for announce chat and make sure we dont show this banner there either.

We can update the logic to temporarily only show this banner at "system" type chat reports.

Who can please implement that?

[mountiny]

@neonbhai looks good but to be on a safe side, lets only show this for system chat report to also catch any other cases like announce chat report

[mountiny]

Removing the blocker label, CP being CPed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: System Footer Visibility #41200

If no regressions arise, payment will be issued on 2024-05-06. 🎊

For reference, here are some details about the assignees on this issue:

• @neonbhai requires payment automatic offer (Contributor)
• @ishpaul777 requires payment automatic offer (Reviewer)

[shubham1206agra]

@mountiny Assign me here for PR review.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: System Footer Visibility #41200

If no regressions arise, payment will be issued on 2024-05-08. 🎊

For reference, here are some details about the assignees on this issue:

• @neonbhai requires payment automatic offer (Contributor)
• @ishpaul777 requires payment automatic offer (Reviewer)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @strepanier03 you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[strepanier03]

Automation didn't kick this back to Daily. Will do that now and review.

[strepanier03]

Just confirming, based on the PR it looks like @shubham1206agra took over reviewer right away and @ishpaul777 is NOT owed payment? If that's incorrect please let me know.

[strepanier03]

Payment Summary

• @neonbhai $250 via Upwork (offer) - paid
• @shubham1206agra $250 via Upwork (offer) - pending acceptance

[strepanier03]

Will check in tomorrow.

[strepanier03]

Contract was accepted so I finished paying it out and closed it.

Everything is all set here, thanks!